Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Send Slack message Github action to separate repository #1595

Closed
piotradamczyk5 opened this issue Feb 12, 2021 · 1 comment · Fixed by #1659
Closed

Move Send Slack message Github action to separate repository #1595

piotradamczyk5 opened this issue Feb 12, 2021 · 1 comment · Fixed by #1659
Assignees
@Sloox
Labels
Feature Tiger 🐯
Milestone
Sprint 3

Comments

@piotradamczyk5
Copy link
Contributor

Flank Github action needs to have action.yml file in the root repository, but now we have another action which we run internally.
Move send message to slack action to separate repository
@zuziaka zuziaka mentioned this issue Mar 1, 2021
Closed
@zuziaka zuziaka added this to the Sprint 3 milestone Mar 1, 2021
@Sloox
Copy link
Contributor

Sloox commented Mar 2, 2021

Please take note that the size of this grows as it includes the #1358 ticket.

@Sloox Sloox mentioned this issue Mar 3, 2021
Merged
1 task
Sloox added a commit that referenced this issue Mar 3, 2021
@Sloox
Merge branch 'master' into #1595-update-slack-send
c8bc561
@Sloox Sloox mentioned this issue Mar 4, 2021
Merged
@mergify mergify bot closed this as completed in #1659 Mar 4, 2021
mergify bot pushed a commit that referenced this issue Mar 4, 2021
@Sloox
feat: Remove flank-actions (#1659)
d2cf060 
Fixes #1595 

## Test Plan
> How do we know the code works?
Its been removed.

Will need to possibly make more modifications after external testing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sloox Sloox

Labels
Feature Tiger 🐯
Projects
None yet
Milestone
Sprint 3
Development

Successfully merging a pull request may close this issue.

feat: Remove flank-actions Flank/flank
4 participants
@Sloox @zuziaka @jan-goral @piotradamczyk5