Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redesign package structure for flank scripts domain #1542

Closed
jan-goral opened this issue Jan 28, 2021 · 1 comment · Fixed by #1583
Closed

Redesign package structure for flank scripts domain #1542

jan-goral opened this issue Jan 28, 2021 · 1 comment · Fixed by #1583
Assignees
@piotradamczyk5
Labels
Refactor Tiger 🐯
Milestone
Sprint 1

Comments

@jan-goral
Copy link
Contributor

jan-goral commented Jan 28, 2021 •
edited
Loading

Requirements

  • The domain layer ("ops") package should not have more than 2 nests inside.
  • Public functions used by CLI commands should be easy to identify and distinguish from internal helper functions.

Describe the solution

  1. Prepare a list of public flank-scripts functions used in CLI commands.
  2. Based on the functions list, identify domains and prepare the proposal for a new packages structure.
@jan-goral jan-goral changed the title Design proper package structure for flank scripts domain Design new package structure for flank scripts domain Jan 28, 2021
@jan-goral jan-goral mentioned this issue Jan 28, 2021
Closed
@jan-goral jan-goral changed the title Design new package structure for flank scripts domain Redesign package structure for flank scripts domain Jan 28, 2021
@zuziaka
Copy link
Contributor

zuziaka commented Feb 1, 2021

@jan-gogo / @piotradamczyk5 / @adamfilipow92 can you provide a sdd document for a whole epic?

@jan-goral jan-goral mentioned this issue Feb 2, 2021
Closed
@zuziaka zuziaka added this to the Sprint 1 milestone Feb 2, 2021
@piotradamczyk5 piotradamczyk5 self-assigned this Feb 9, 2021
@piotradamczyk5 piotradamczyk5 mentioned this issue Feb 9, 2021
Merged
@mergify mergify bot closed this as completed in #1583 Feb 10, 2021
mergify bot pushed a commit that referenced this issue Feb 10, 2021
@piotradamczyk5
docs: flank-scripts ops package organization (#1583)
38849bc 
Fixes #1542 

This is a proposal on how to organize `ops` package inside **flank-scripts**
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@piotradamczyk5 piotradamczyk5

Labels
Refactor Tiger 🐯
Projects
None yet
Milestone
Sprint 1
Development

Successfully merging a pull request may close this issue.

docs: flank-scripts ops package organization Flank/flank
3 participants
@zuziaka @jan-goral @piotradamczyk5