Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iOS | flank-scripts for generating test artifacts #1345

Closed
zuziaka opened this issue Nov 24, 2020 · 0 comments · Fixed by #1350
Closed

iOS | flank-scripts for generating test artifacts #1345

zuziaka opened this issue Nov 24, 2020 · 0 comments · Fixed by #1350
Assignees
@zuziaka
Labels
iOS Refactor Tiger 🐯

Comments

@zuziaka
Copy link
Contributor

zuziaka commented Nov 24, 2020 •
edited
Loading

Goal of this ticket is to:

  • clean up ios test artifacts
  • make names future-proof (no Xcode version in file names)
  • remove duplicated artifacts (mostly EarlGrey example)
  • add flank scripts for generating: iOS gameloop example and test plans example

Currently there is a lot of floating files:
Screenshot 2020-11-24 at 13 40 04
@zuziaka zuziaka self-assigned this Nov 24, 2020
@zuziaka zuziaka added the iOS label Nov 24, 2020
zuziaka added a commit that referenced this issue Nov 24, 2020
@zuziaka
Revert "Flank scripts for generating test artifacts"
efee6ee 
This reverts commit bc03d64.

Flank scripts for generating game loop artifacts will be added in #1345
@zuziaka zuziaka mentioned this issue Nov 24, 2020
Merged
2 tasks
bootstraponline pushed a commit that referenced this issue Nov 24, 2020
@zuziaka
Revert "Flank scripts for generating test artifacts"
e4b7944 
This reverts commit bc03d64.

Flank scripts for generating game loop artifacts will be added in #1345
mergify bot pushed a commit that referenced this issue Nov 25, 2020
@zuziaka
feat: IOS GameLoop addition (#1325)
3075194 
This PR adds iOS example project with a game loop.

Scripts for generating IPA file from iOS source code will be added in:
#1345

Support for game loop in Flank will be fully implemented in:
#1341


## Test Plan
> How do we know the code works?

.

## Checklist

- [x] Documented
- [x] Unit tested

_____

Bottom note: Flank doesn't support gameloop mode for iOS yet. 
Flank requires xctestrun-file which doesn't exist in gameloop mode. #1341
@zuziaka zuziaka changed the title iOS | flank-scripts for generating test artifacats iOS | flank-scripts for generating test artifacts Nov 25, 2020
@zuziaka zuziaka mentioned this issue Nov 25, 2020
Merged
2 tasks
@zuziaka zuziaka linked a pull request Nov 25, 2020 that will close this issue
refactor: ios test artifacts cleanup #1345 #1350
Merged
2 tasks
@mergify mergify bot closed this as completed in #1350 Dec 1, 2020
mergify bot pushed a commit that referenced this issue Dec 1, 2020
@zuziaka
refactor: ios test artifacts cleanup #1345 (#1350)
3de1718 
#1345 - iOS Tests artifacts cleanup

Changes:
* renamed some variables inside flankScripts/ios 
* added scripts for generating IPA file instead of .xctestrun for gameloop example
* reorganised test artefacts (removed unused files, moved them to correct directories
* renamed *FlankMultiTestTargetsExample* to *FlankTestPlansExample* // CC: @jan-gogo  
* changed all references to old test artefacts
* rebuilded EarlGrey example with compatible Xcode version

Previously:
<img width="1046" alt="Screenshot 2020-11-25 at 13 36 07" src="https://user-images.githubusercontent.com/31246956/100228584-2f5e4480-2f23-11eb-9292-112335fd3db1.png">

Now:
<img width="1009" alt="Screenshot 2020-11-25 at 13 28 07" src="https://user-images.githubusercontent.com/31246956/100228420-f1f9b700-2f22-11eb-95db-b9291d83cc38.png">

## Test Plan
> How do we know the code works?

1. If you want to easily notice that artifact generation is working correctly you can clear your linked local `test_artifacts` directory.
1. Run `flankScripts shell ops ios`, this command should generate all ios artifacts one by one, and copy each to local `test_artifacts` dir.
1. Make sure the console log doesn't show any error.
1. Make sure the `test_artifacts` directory is containing the following directories: [ EarlGreyExample, FlankExample, FlankGameLoopExample, FlankTestPlansExample ]
1. Run tests manually on each ios project and make sure the results are the same as expected (This step should be widely detailed and updated!!!).

## Checklist

- [x] Documented
- [x] Unit tested
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zuziaka zuziaka

Labels
iOS Refactor Tiger 🐯
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: ios test artifacts cleanup #1345 Flank/flank
1 participant
@zuziaka