Check and improve uploading file console output #1334
Comments
4 tasks
mergify bot
pushed a commit
that referenced
this issue
Dec 31, 2020
Fixes #1334 Previous uploading Flank output looks like: ``` Saved 1 shards to android_shards.json Uploading android_shards.json . Uploading app-debug.apk . Uploading app-debug-androidTest.apk . 1 test / 1 shard 1 matrix ids created in 0m 3s https://console.developers.google.com/storage/browser/test-lab-v9cn46bb990nx-kz69ymd4nm9aq/test_dir ``` The new output for file upload looks more like Gcloud output: ``` Saved 1 shards to android_shards.json Uploading [android_shards.json] to https://console.developers.google.com/storage/browser/test-lab-v9cn46bb990nx-kz69ymd4nm9aq/test_dir/... Uploading [app-debug.apk] to https://console.developers.google.com/storage/browser/test-lab-v9cn46bb990nx-kz69ymd4nm9aq/test_dir/... Uploading [app-debug-androidTest.apk] to https://console.developers.google.com/storage/browser/test-lab-v9cn46bb990nx-kz69ymd4nm9aq/test_dir/... 1 test / 1 shard 1 matrix ids created in 0m 3s Raw results will be stored in your GCS bucket at [https://console.developers.google.com/storage/browser/test-lab-v9cn46bb990nx-kz69ymd4nm9aq/test_dir] ``` Gcloud file upload output for reference: ``` Uploading [test_runner/../test_projects/android/apks/app-debug.apk] to Firebase Test Lab... Uploading [test_runner/../test_projects/android/apks/app-debug-androidTest.apk] to Firebase Test Lab... Raw results will be stored in your GCS bucket at [https://console.developers.google.com/storage/browser/test-lab-v9cn46bb990nx-kz69ymd4nm9aq/test_dir/] ``` ## Test Plan > How do we know the code works? 1. Run Flank 1. Check output 1. Output for file upload looks like described above ## Checklist - [x] Research done - [x] Some refactor of output - [x] Unit tested - [x] Integration tests updated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Author the user story for this feature
As a User, I want to improve output for uploading files so I can easily see which files are uploaded.
Describe the solution
Based on discussion in PR
Let's decide what we want to print actually when we uploading files to gcloud.
Currently, we just print the message
Uploading [file name]do we want to stick with that? Or we can print a gcs link but on a matrix level? So every matrix will have it's own. IMO we should decide on one convention and not mix them
The text was updated successfully, but these errors were encountered: