Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate moving to Sentry from BugSnag #1318

Closed
bootstraponline opened this issue Nov 13, 2020 · 4 comments · Fixed by #1471
Closed

Evaluate moving to Sentry from BugSnag #1318

bootstraponline opened this issue Nov 13, 2020 · 4 comments · Fixed by #1471
Assignees
Labels

Comments

@bootstraponline
Copy link
Contributor

Author the user story for this feature

As a Flank developer, I want to understand crashes in Flank so I can fix them.

Describe the solution

Evaluate Sentry as a BugSnag alternative.

@adamfilipow92
Copy link
Contributor

Sentry have java lib with example available here
also, we can register Flank on Sentry for Open Source maybe we get higher quotes to make flank more awesome 😄
WDYT?

@bootstraponline
Copy link
Contributor Author

Sentry approved Flank for an open source account! I can add the team once we're ready to work on this

@adamfilipow92
Copy link
Contributor

Sentry have java library

Initialization

  1. Bugsnag
Bugsnag(API_KEY)
  1. Sentry
Sentry.init {
        it.dsn = DNS_URL
    }

Logging errors

  1. Bugsnag
bugsnag?.notify(error)
  1. Sentry
 Sentry.captureException(error)

Additional data

We can set

  1. release number
  2. user
  3. tags (here we can put additional information like os version)

Events can be filtered by user, tag, event level. This feature can be helpful when we need to find a specific issue for a specific system.

We login errors to bugsnag in 2 places

  1. executeWithRetry
  2. withGlobalExceptionHandling

I think we can also log: Flank version, os name, and run id to easier finding crashes for a specific user. We could display this information before Flank version. It could help with finding errors for specific cases.

WDYT?

@bootstraponline
Copy link
Contributor Author

That sounds awesome

@mergify mergify bot closed this as completed in #1471 Jan 11, 2021
mergify bot pushed a commit that referenced this issue Jan 11, 2021
Fixes #1318 

## Test Plan
> How do we know the code works?

1. Flank should display session id below ```revision```
2. Should save session id to ```session_id.txt``` in matrix path
3. Should upload ```session_id.txt``` when ```disable-results-upload``` not set
4. Unit & Integration tests should pass

## Checklist

- [X] Save and upload session id
- [X] Unit tested
- [X] Integration tests updated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants