Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPIKE] Flank's run flow -- refactor #1317

Closed
pawelpasterz opened this issue Nov 13, 2020 · 2 comments · Fixed by #1588
Closed

[SPIKE] Flank's run flow -- refactor #1317

pawelpasterz opened this issue Nov 13, 2020 · 2 comments · Fixed by #1588
Assignees
@pawelpasterz @jan-goral
Labels
Research Tiger 🐯
Milestone
Sprint 4

Comments

@pawelpasterz
Copy link
Contributor

pawelpasterz commented Nov 13, 2020 •
edited by zuziaka
Loading

Story

As a flank committer, I'd like to be able to add new features easily and in a straightforward way.

Detailed info/background

Recently lots of new code was added to the master (new features, bug fixes, etc.). Sometimes it's hard to implement something due to strongly coupled code and unclear logic. Because of that, it takes more and more time to implement solutions as well as to make correct reviews. In order to make everyone's life easier, we should put some effort to track down places in flank's code which we can refactor to be clear and readable, yet concise and robust.

Result

As a result, a new epic with SDD will be created with detailed info on what should be refactored, with guidelines if possible.
@piotradamczyk5 piotradamczyk5 mentioned this issue Jan 28, 2021
Closed
@pawelpasterz pawelpasterz self-assigned this Jan 29, 2021
@zuziaka
Copy link
Contributor

zuziaka commented Feb 1, 2021

@pawelpasterz @jan-gogo could you research it and convert it to Epic?

@jan-goral
Copy link
Contributor

jan-goral commented Feb 2, 2021 •
edited
Loading

@axelzuziak-gogo I have changed the label to the tiger. We can estimate it as research and start working on it ASAP. In the description is mentioned that the result of this research will be a fully described epic.

@zuziaka zuziaka assigned jan-goral and pawelpasterz and unassigned pawelpasterz Feb 2, 2021
@zuziaka zuziaka added this to the Sprint 1 milestone Feb 2, 2021
@jan-goral jan-goral mentioned this issue Feb 11, 2021
Merged
@zuziaka zuziaka modified the milestones: Sprint 1, Sprint 2 Feb 15, 2021
@zuziaka zuziaka modified the milestones: Sprint 2, Sprint 3 Mar 1, 2021
@zuziaka zuziaka modified the milestones: Sprint 3, Sprint 4 Mar 15, 2021
@mergify mergify bot closed this as completed in #1588 Mar 26, 2021
mergify bot pushed a commit that referenced this issue Mar 26, 2021
@jan-goral
refactor: Investigate and create proposal (#1588)
912f584 
Fixes #1317 

* [investigation](https://github.com/Flank/flank/blob/1317-flank-run-refactor/docs/refactor/investigation.md)
* [diagram](https://github.com/Flank/flank/blob/1317-flank-run-refactor/docs/refactor/diagram.md)
* [proposal](https://github.com/Flank/flank/blob/1317-flank-run-refactor/docs/refactor/proposal.md)
* [steps](https://github.com/Flank/flank/blob/1317-flank-run-refactor/docs/refactor/steps.md)
jan-goral added a commit that referenced this issue Mar 26, 2021
@jan-goral
refactor: Investigate and create proposal (#1588)
3abbfd5 
Fixes #1317 

* [investigation](https://github.com/Flank/flank/blob/1317-flank-run-refactor/docs/refactor/investigation.md)
* [diagram](https://github.com/Flank/flank/blob/1317-flank-run-refactor/docs/refactor/diagram.md)
* [proposal](https://github.com/Flank/flank/blob/1317-flank-run-refactor/docs/refactor/proposal.md)
* [steps](https://github.com/Flank/flank/blob/1317-flank-run-refactor/docs/refactor/steps.md)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pawelpasterz pawelpasterz

@jan-goral jan-goral

Labels
Research Tiger 🐯
Projects
None yet
Milestone
Sprint 4
Development

Successfully merging a pull request may close this issue.

refactor: Investigate and create proposal Flank/flank
3 participants
@zuziaka @pawelpasterz @jan-goral