Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git hook lint before commit #1305

Closed
Sloox opened this issue Nov 9, 2020 · 2 comments · Fixed by #1320
Closed

Git hook lint before commit #1305

Sloox opened this issue Nov 9, 2020 · 2 comments · Fixed by #1320
Assignees
Labels

Comments

@Sloox
Copy link
Contributor

Sloox commented Nov 9, 2020

Author the user story for this feature

As i run the git add, git commit. I want lint to run to highlight issues with my code so I don't have to build the entire project or find the errors with detekt on GitHub actions.

Describe the solution
Add a git hook that runs either klint or detekt on git commit.

@Sloox Sloox added the Feature label Nov 9, 2020
@Sloox
Copy link
Contributor Author

Sloox commented Nov 16, 2020

Author the user story for this feature

As i run the git add, git commit. I want lint to run to highlight issues with my code so I don't have to build the entire project or find the errors with detekt on GitHub actions.

Describe the solution
Add a git hook that runs either klint or detekt on git commit.

Can also include the wrapping of parameters here @jan-gogo

@Sloox Sloox self-assigned this Nov 16, 2020
@Sloox
Copy link
Contributor Author

Sloox commented Nov 16, 2020

I will remove the detekt task running on every build or gradle execution It adding unnecessary time to our builds

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant