Skip to content

Commit

Permalink
CR fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
jan-goral authored and mergify-bot committed Sep 15, 2020
1 parent a5f4ee6 commit d55f857
Show file tree
Hide file tree
Showing 5 changed files with 11 additions and 4 deletions.
7 changes: 7 additions & 0 deletions docs/test_artifacts.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,13 @@ update_test_artifacts android ios # [ android | go | ios | all ]
```
`update_test_artifacts` function will generate artifacts and copy them to `test_runner/src/test/kotlin/ftl/fixtures/tmp/` directory.

### Test projects
All source code for test artifacts is located in [test_projects](../test_projects/) directory.

Each test project can contain own `ops.sh` script used building and coping generated artifacts.

`update_test_artifacts` function is located in [test_projects/ops.sh](../test_projects/ops.sh) script.

# Refactor
This is proposal of test artifacts refactoring.

Expand Down
2 changes: 1 addition & 1 deletion test_projects/android/bash/generate-multi-modules-apks.sh
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#!/usr/bin/env bash

echo "DEPRECATED!!!"
echo "DEPRECATED!!! use functions from test_projects/android/ops.sh"

set -euxo pipefail

Expand Down
2 changes: 1 addition & 1 deletion test_projects/android/bash/generate_apks.sh
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#!/usr/bin/env bash

echo "DEPRECATED!!!"
echo "DEPRECATED!!! use functions from test_projects/android/ops.sh"

set -euxo pipefail

Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#!/usr/bin/env bash

echo "DEPRECATED!!!"
echo "DEPRECATED!!! use functions from test_projects/android/ops.sh"

set -euxo pipefail

Expand Down
2 changes: 1 addition & 1 deletion test_projects/ios/EarlGreyExample/ops.sh
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ EARL_GREY_EXAMPLE="$TEST_PROJECTS_IOS/EarlGreyExample"

function setup_ios_env() {
if ! [ -x "$(command -v xcpretty)" ]; then
gem install cocoapods
gem install cocoapods -v 1.9.3
fi
(cd "$EARL_GREY_EXAMPLE" && pod install)
}
Expand Down

0 comments on commit d55f857

Please sign in to comment.