Skip to content

Commit

Permalink
Add comment in code
Browse files Browse the repository at this point in the history
  • Loading branch information
pawelpasterz committed Aug 3, 2020
1 parent 818e591 commit c9926e9
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions test_runner/src/main/kotlin/ftl/json/SavedMatrix.kt
Original file line number Diff line number Diff line change
Expand Up @@ -148,9 +148,11 @@ class SavedMatrix(matrix: TestMatrix) {
flakyOutcome: Boolean
) {
outcome = when {
// the matrix outcome is failure if any step fails
// if the matrix outcome is already set to failure then we can ignore the other step outcomes.
// inconclusive is treated as a failure
// The matrix outcome is failure if any step fails
// If the matrix outcome is already set to failure then we can ignore the other step outcomes.
// Inconclusive is treated as a failure
// This particular conditions order should not be changed, for more details check:
// https://github.com/Flank/flank/issues/914
outcome == failure || outcome == inconclusive -> return
flakyOutcome -> flaky
outcome == flaky -> this?.summary?.takeIf { it == failure || it == inconclusive }
Expand Down

0 comments on commit c9926e9

Please sign in to comment.