Skip to content

Commit

Permalink
update
Browse files Browse the repository at this point in the history
  • Loading branch information
jan-goral authored and mergify-bot committed Mar 24, 2021
1 parent 21e212b commit c43ce42
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
6 changes: 3 additions & 3 deletions docs/refactor/investigation.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ This document is and entity point for further improvements.

#### Issues

1. `ftl.Main` command shouldn't be bound with `main` function with constructor
1. `ftl.Main` command shouldn't be bound with `main` function through companion object due to single responsibility principle.
1. Some commands that can run domain code are doing too much.
1. Some of composing commands seem to be in wrong package.

Expand Down Expand Up @@ -103,7 +103,7 @@ command that:
1. The domain layer of flank is not clearly separated of CLI and external APIs.
1. Domain logic is huge and complicated but there is lack of diagram for visualize it.

### Data [ consider better name ]
### Data & Adapters

#### Issues

Expand Down Expand Up @@ -525,4 +525,4 @@ where
* `IArgs.uploadIfNeeded` -> `FileReference.uploadIfNeeded` -> `GcStorage.upload`
* `GcIosTestMatrix/build`
* `AbstractGoogleJsonClientRequest<T>/executeWithRetry`
* `IArgs/afterRunTests` - the rest of steps are same as for android
* `IArgs/afterRunTests` - the rest of steps are same as for android
8 changes: 4 additions & 4 deletions docs/refactor/proposal.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Flank refactor proposal [Not complete]
# Flank refactor proposal

## Motivation

Expand Down Expand Up @@ -36,8 +36,8 @@ but from technical perspective those will be interfaces, type aliases, and struc
* ftl
* cli
* domain
* data ?
* adapters ?
* data
* adapters
* utils


Expand Down Expand Up @@ -107,4 +107,4 @@ which will be a bridge between domain and external APIs.

* New package for grouping wrappers and adapters for external APIs.
* Consider separated package in `ftl` only for interfaces and structures, shared between api adapters and domain.
* External API structures and function cannot leak to other layers.
* External API structures and function cannot leak to other layers.

0 comments on commit c43ce42

Please sign in to comment.