Update docs and remove png again

Flank · Jan 8, 2019 · 28364ed · 28364ed
1 parent 496377c
commit 28364ed
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 4 deletions.
diff --git a/contributing.md b/contributing.md
@@ -21,6 +21,10 @@ See the main readme for instructions on how to run the iOS and Android samples.
 - Update `IArgs` with new property
 - Update `AndroidArgs` to reference the propery and update `toString`
 - Update `IosArgs` to reference the propery and `toString`
+- Add test to `IosArgsTest`
+- Add test to `IosRunCommandTest` and update `empty_params_parse_null` test
+- Add test to `AndroidArgsTest`
+- Add test to `AndroidRunCommandTest` and update `empty_params_parse_null` test
 
 ## CLA
 

diff --git a/test_runner/flank.ios.yml b/test_runner/flank.ios.yml
@@ -41,3 +41,7 @@ flank:
   #
   # test-targets:
   #   - b/testBasicSelection
+
+  # # directories to download after the test runs from the result bucket
+  # directories-to-download:
+  #   - /sdcard/screenshots
diff --git a/test_runner/src/main/kotlin/ftl/run/TestRunner.kt b/test_runner/src/main/kotlin/ftl/run/TestRunner.kt
@@ -188,7 +188,7 @@ object TestRunner {
         return MatrixMap(map, path)
     }
 
-    /** fetch test_result_0.xml & *.png **/
+    /** fetch test_result_0.xml **/
     private fun fetchArtifacts(matrixMap: MatrixMap) {
         println("FetchArtifacts")
         val fields = Storage.BlobListOption.fields(Storage.BlobField.NAME)

diff --git a/test_runner/src/main/kotlin/ftl/util/ArtifactRegex.kt b/test_runner/src/main/kotlin/ftl/util/ArtifactRegex.kt
@@ -7,8 +7,6 @@ object ArtifactRegex {
 
     @VisibleForTesting
     val testResultRgx = Regex(".*test_result_\\d+\\.xml$")
-    @VisibleForTesting
-    val screenshotRgx = Regex(".*\\.png$")
 
     /**
      * @return a list of regex's that should be downloaded
@@ -17,6 +15,6 @@ object ArtifactRegex {
         val directoriesRegexToDownload = directoriesToDownload
             .map { "^${Regex.escape(matrix.gcsPathWithoutRootBucket)}/.*/artifacts${Regex.escape(it)}/.*" }
             .map { Regex(it) }
-        return listOf(testResultRgx, screenshotRgx) + directoriesRegexToDownload
+        return listOf(testResultRgx) + directoriesRegexToDownload
     }
 }