Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Metrics storybook design #1462
docs: Metrics storybook design #1462
Changes from 36 commits
a55f8f7
42a6f9d
7f64e10
0fb105b
fdf91e3
a67ccb0
0bd4540
b6b8bf2
f704d0d
cc4cce2
6d8b46e
81b7664
75354df
6e3326d
74355ec
32cce7f
f1b99fd
9f8abac
216cfed
10b7387
cd926f5
7caefda
ee0b355
5d129be
2e475e0
9fa393b
d28c560
4943cec
4a3cfe5
eb7a521
959a004
cea541e
9069f98
f4c2f82
d2d9f4c
d5de77f
d9cad8f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📱
What do you think about splitting the data model and the view into different classes? I believe it would be great to have a widget and a
Chapter
model for each Metrics widget. Also, I believe it would be cleaner and more structured if we'll have view models for each Metrics widget and for each widget representing aChapterControl
so that we'll have aChangeNotifier
containing a list ofStories
and a selectedChapter
. Also, we'll have aChangeNotifier
that will hold and control theChapterControls
for the selectedChapter
and provide a view model used to build it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:readable:
Would it be great to explain the way of creation of the
ChapterControls
?