NEST 2.3.0 models update #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertsjames
force-pushed
the
RJ-ER_update
branch
from
e28e664 to
b904be5
Compare
Merged
…after ER models and extraction model changed).
…eters, set er_free_b to new NEST value for LZ and nNT fits.
…k to LUX defaults.
… useTiming=-1 mode. Will not work in compute() as it stands, will have to make further approximations.
… work in compute(). Still need to make fully TF-compatible.
…lso, add in spe_thr to config. (seperate out from minimum S1 cut), and have this as an additional cut in final_signals.py.
…NEST for LUX (2).
…k speeds things back up...
…tion with no smearing.
… override certain attributes.
robertsjames
force-pushed
the
RJ-ER_update
branch
from
b904be5 to
1a38a35
Compare
|
Hi @JelleAalbers I rebased, so if you can approve I'll put this one in first, followed by #252 |
flamedisx/utils.py
Outdated
|
|
||
|
|
||
| @export | ||
| def log10(x): |
There was a problem hiding this comment.
We already have this in utils.py, it's called tf_log10. So this one isn't needed.
JelleAalbers
approved these changes
Aug 24, 2022
|
Removed the duplicate function, will merge now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary/validations here.