feat: evaluator module #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
khvn26
commented
Sep 14, 2023
khvn26
commented
- Move segment rule evaluators to flag_engine.segments.evaluator module
- Add missing runtime type checks
- Move segment rule evaluators to flag_engine.segments.evaluator module - Add missing runtime type checks
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 1d2b802 |
gagantrivedi
requested changes
Sep 15, 2023
gagantrivedi
requested changes
Sep 18, 2023
| from pydantic import BaseModel, Field | ||
|
|
||
| from flag_engine.features.models import FeatureStateModel | ||
| from flag_engine.segments import constants | ||
| from flag_engine.segments.types import ConditionOperator, RuleType | ||
| from flag_engine.utils.semver import is_semver | ||
| from flag_engine.utils.types import get_casting_function | ||
|
|
||
|
|
||
| class SegmentConditionModel(BaseModel): |
There was a problem hiding this comment.
_EXCEPTION_OPERATOR_METHODS can be removed now, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.