Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: decimal trait values #187

Merged
merged 3 commits into from
Aug 8, 2023
Merged

fix: decimal trait values #187

merged 3 commits into from
Aug 8, 2023

Conversation

khvn26
Copy link
Member

@khvn26 khvn26 commented Aug 8, 2023

This PR fixes two issues:

  1. When passing a decimal.Decimal as trait value, the engine will check if it's an actual integer value instead of blindly coercing to float.
  2. When coercing a numeric string, the engine will try int before float.

@khvn26 khvn26 requested a review from matthewelwell August 8, 2023 09:46
@github-actions
Copy link

github-actions bot commented Aug 8, 2023

File Coverage
All files 100% ✅

Minimum allowed coverage is 100%

Generated by 🐒 cobertura-action against 3212e74

@khvn26 khvn26 merged commit bf43ccb into main Aug 8, 2023
@khvn26 khvn26 deleted the fix/decimal-trait-values branch August 8, 2023 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewelwell matthewelwell matthewelwell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@khvn26 @matthewelwell