Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Bypass server-side filtering for server keys #130

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

MCPx
Copy link
Contributor

@MCPx MCPx commented Nov 13, 2024

As suggested by @matthewelwell in this issue, this workaround allows for adding server keys to the edge proxy that will bypass filtering of server-side only features, e.g.

"environment_key_pairs": [
    {
      "client_side_key": "abc123",
      "server_side_key": "ser.def456"
    },
    {
      "client_side_key": "ser.def456",
      "server_side_key": "ser.def456"
    }
  ],

Tests added to ensure that the three places that use filter_out_server_key_only_feature_states are covered and confirmed to be returning the feature that is filtered out for a client side key.

Copy link
Member

@khvn26 khvn26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@matthewelwell matthewelwell merged commit a3e8fbd into Flagsmith:main Nov 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants