Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop feather dependency #987

Merged
merged 4 commits into from
Mar 2, 2022
Merged

Drop feather dependency #987

merged 4 commits into from
Mar 2, 2022

Conversation

rush42
Copy link
Contributor

@rush42 rush42 commented Mar 2, 2022

This PR closes #729 and uses local files instead of the ones from the react-feather package

How Has This Been Tested?

Not yet.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@rush42 rush42 requested a review from ohrie March 2, 2022 14:08
@codecov
Copy link

codecov bot commented Mar 2, 2022

Codecov Report

Merging #987 (34fe0e2) into develop (f5f3df1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #987   +/-   ##
========================================
  Coverage    36.43%   36.43%           
========================================
  Files          500      500           
  Lines         9446     9446           
  Branches      1948     1948           
========================================
  Hits          3442     3442           
  Misses        5718     5718           
  Partials       286      286           
Flag Coverage Δ
unittests 36.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../Reports/pages/OverviewMap/components/CTAButton.js 0.00% <ø> (ø)
...ubmitReport/components/LocateMeMap/StaticMarker.js 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5f3df1...34fe0e2. Read the comment docs.

@ohrie
Copy link
Contributor

ohrie commented Mar 2, 2022

I would prefer putting the icons directly into the component folders, since they are not used in other components

@rush42 rush42 merged commit 2a28698 into develop Mar 2, 2022
@rush42 rush42 deleted the drop_feather_dependency branch March 2, 2022 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace react-feather icon imports with svg assets
2 participants