Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NPM doesn't add JSDom's dependency to package-lock.json #673

Open
cafca opened this issue Nov 23, 2020 · 4 comments
Open

NPM doesn't add JSDom's dependency to package-lock.json #673

cafca opened this issue Nov 23, 2020 · 4 comments
Labels
bug Something isn't working dependencies Topics regarding dependency files / updates help wanted Extra attention is needed

Comments

@cafca
Copy link
Collaborator

cafca commented Nov 23, 2020 •
edited
Loading

JSDOM lists request^2.88.2 as a dependency but running npm install doesn't add request to package-lock.json. I have added request as a top-level dev-dependency for now, but that's not a sustainable solution.

Steps to reproduce:

  1. Uninstall my added top-level request dependency with npm uninstall request
  2. Run npm install
  3. Search for "request" in package-lock.json

Expected result:

request is listed in JSDOM's dependencies field.

Actual result:

JSDOM's dependencies field does not contain request.
@cafca cafca added the bug Something isn't working label Nov 23, 2020
@cafca cafca changed the title NPM doesn't add JSDom dependency request to package-lock.json NPM doesn't add JSDom dependency to package-lock.json Nov 23, 2020
cafca added a commit that referenced this issue Nov 23, 2020
@cafca
Fix npm package-lock issue temporarily
5f9c6a8 
Adds `request` dependency of JSDom. See issue at
#673
cafca added a commit that referenced this issue Nov 23, 2020
@dependabot-preview @cafca
Bump start-server-and-test from 1.10.11 to 1.11.6 (#667)
d8ebc47 
* Bump start-server-and-test from 1.10.11 to 1.11.6

Bumps [start-server-and-test](https://github.com/bahmutov/start-server-and-test) from 1.10.11 to 1.11.6.
- [Release notes](https://github.com/bahmutov/start-server-and-test/releases)
- [Commits](bahmutov/start-server-and-test@v1.10.11...v1.11.6)

Signed-off-by: dependabot-preview[bot] <[email protected]>

* Hack to allow clearing GH build cache

* Fix npm package-lock issue temporarily

Adds `request` dependency of JSDom. See issue at
#673

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Co-authored-by: Vincent Ahrend <[email protected]>
@cafca cafca changed the title NPM doesn't add JSDom dependency to package-lock.json NPM doesn't add JSDom's dependency to package-lock.json Nov 23, 2020
@cafca cafca added the help wanted Extra attention is needed label Jan 14, 2021
@ohrie ohrie added the dependencies Topics regarding dependency files / updates label Jan 13, 2022
@s-pic
Copy link
Collaborator

s-pic commented Jan 17, 2022

@cafca Mind me taking a look at this?

@ohrie
Copy link
Contributor

ohrie commented Mar 3, 2022

I don't understand the problem correctly. Where do we need jsdom? It does not appear in the package.json. Only Jest needs it. But adds it correctly. The test run fine.

@s-pic
Copy link
Collaborator

s-pic commented Mar 3, 2022

Guess this regards to the lock file, not the package file

@ohrie
Copy link
Contributor

ohrie commented Mar 3, 2022

Yeah, you're right. But when jsdom doesn't include request, why should be add it? ^^ Where does jsdom or out project need it, didn't find it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working dependencies Topics regarding dependency files / updates help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cafca @ohrie @s-pic