src: impl Try for Response, change Middleware/Endpoints #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because apparently cookie-0.14.1 uses a feature flag in docs
Requires `#![feature(try_trait)]` and will only compile on rust nightly! Moves away from `Ok(res)` and `Ok(impl Into<Response>` in favor of returning `Response` directly, with error propogation via `?` handled by the `Try` trait.
This was referenced Jun 9, 2020
Merged
Fishrock123
force-pushed
the
new-http-types-errors
branch
6 times, most recently
from
cd9568a
to
d5e4e66
Compare
Fishrock123
force-pushed
the
new-http-types-errors
branch
2 times, most recently
from
9bf7c09
to
2c59a63
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires
#![feature(try_trait)]and will only compile on rust nightly!Moves away from
Ok(res)andOk(impl Into<Response>in favor of returningResponsedirectly, with error propogation via?handled by theTrytrait.