Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the test trait to permit rethrown exceptions #63

Merged
merged 5 commits into from
Jun 21, 2018
Merged

Conversation

Firehed
Copy link
Owner

@Firehed Firehed commented Jun 21, 2018

The main goal of this is to make it easy to implement handleException in v3.1 as a no-op rethrow without causing all of the trait-added tests to fail.

@codecov
Copy link

codecov bot commented Jun 21, 2018

Codecov Report

Merging #63 into master will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #63      +/-   ##
============================================
+ Coverage     96.11%   96.18%   +0.06%     
- Complexity      114      117       +3     
============================================
  Files            25       25              
  Lines           335      341       +6     
============================================
+ Hits            322      328       +6     
  Misses           13       13
Impacted Files Coverage Δ Complexity Δ
src/Traits/EndpointTestCases.php 94.44% <ø> (ø) 11 <0> (ø) ⬇️
src/Traits/HandlesOwnErrorsTestCases.php 100% <100%> (ø) 5 <4> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07256ad...29cd59d. Read the comment docs.

@Firehed Firehed merged commit bc311b4 into master Jun 21, 2018
@Firehed Firehed deleted the allow_rethrown branch June 21, 2018 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant