Allow top-level error handler within dispatcher #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates a new interface for handling any exception that an endpoint throws without forcing the endpoint to implement its own error handler.
The end-goal for this is to be able to extract the
handleExceptionmethod inEndpointInterfaceinto its own interface, so that in the next major (?) version, error handling at a per-endpoint level becomes completely optional. This cuts way down on boilerplate, since relatively few endpoints (in my experience) need their own error handling logic, and the main use case for that tended to be for formatting the response to an appropriate content-type based on what was implied (but not actually stated!) by the request.