-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix TODOs in #546 #575
Merged
Merged
Fix TODOs in #546 #575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #575 +/- ##
==========================================
+ Coverage 66.07% 66.12% +0.04%
==========================================
Files 277 277
Lines 36946 36946
==========================================
+ Hits 24413 24430 +17
+ Misses 10773 10761 -12
+ Partials 1760 1755 -5
|
torao
approved these changes
Mar 7, 2023
torao
added
the
C: enhancement
Classification: New feature or its request, or improvement in maintainability of code
label
Mar 7, 2023
ulbqb
approved these changes
Mar 7, 2023
Kynea0b
approved these changes
Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C: enhancement
Classification: New feature or its request, or improvement in maintainability of code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I left some TODOs in #546 and I fix them. In addition, I checked by comparing with
tendermint-v0.34.19
and sorted the imports so that the difference withtendermint-v0.34.19
is minimal.TODOs:
Correction point of view
When using the following combinations, basically, keep Tendermint and use the
oc
prefix for Ostracontypes/octypes
abcitypes/ocabcitypes
Remarks