Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Modify omission of change to change ValidatorSet to VoterSet for marverick #345

Merged
merged 2 commits into from
Nov 19, 2021
Merged

fix: Modify omission of change to change ValidatorSet to VoterSet for marverick #345

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
78c117c
fix: Modify omission of change to change ValidatorSet to VoterSet for…
Kynea0b Nov 17, 2021
2bac1b2
fix: Change the description of maverick in contibuting.md
Kynea0b Nov 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,8 +338,8 @@ cd test/e2e && \

### Maverick

**If you're changing the code in `consensus` package, please make sure to
replicate all the changes in `./test/maverick/consensus`**. Maverick is a
**If you're changing the code in `consensus` package or `node` package, please make sure to
replicate all the changes in `./test/maverick/consensus`** and `./test/maverick/node`**. Maverick is a
byzantine node used to assert that the validator gets punished for malicious
behavior.

Expand Down
2 changes: 1 addition & 1 deletion test/maverick/consensus/state.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1807,7 +1807,7 @@ func (cs *State) signVote(
return nil, errPubKeyIsNotSet
}
addr := cs.privValidatorPubKey.Address()
valIdx, _ := cs.Validators.GetByAddress(addr)
valIdx, _ := cs.Voters.GetByAddress(addr)

vote := &types.Vote{
ValidatorAddress: addr,
Expand Down