-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove t.Skip in testcases #307
Conversation
1a26061
to
e7dab01
Compare
Codecov Report
@@ Coverage Diff @@
## main #307 +/- ##
==========================================
+ Coverage 61.18% 62.91% +1.73%
==========================================
Files 272 272
Lines 29988 30166 +178
==========================================
+ Hits 18347 18978 +631
+ Misses 9963 9481 -482
- Partials 1678 1707 +29
|
7a1267e
to
370c211
Compare
- TestHandshakeReplayAll - TestHandshakeReplaySome - TestHandshakeReplayOne - TestHandshakeReplayNone - TestMockProxyApp
e0edfda
to
131fc7c
Compare
Addressed the below:
Keep
|
if !pubKey1.Equals(pubKey2) { | ||
// block creator must be the cs.privValidator | ||
cs1.privValidator = vs.PrivValidator | ||
cs1.privValidatorPubKey = pubKey2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These technics are happened deadlock
by cs1.createProposalBlock(round)
with test --race
. And I made createProposalBlockSlim
.
*/ | ||
|
||
// Chi-squared test for `SelectProposer` | ||
chiSquareds := make([]ChiSquared, N) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I replaced frequencies test(bound: margin of error)
with Chi-squared test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
I fixed
t.Skip
andt.Skipf
test cases.