-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: don't use foo-bar.net in TestHTTPClientMakeHTTPDialer #174
Conversation
This test relied on connecting to the external site `foo-bar.net`, and (predictably) the site went down and broke all of our CI runs. This changes it to use local HTTP servers instead. (cherry picked from commit f54f80bf0d464ffec6facf98e447ee403bbf1e8c)
Codecov Report
@@ Coverage Diff @@
## develop #174 +/- ##
===========================================
- Coverage 62.52% 62.43% -0.09%
===========================================
Files 283 283
Lines 26475 26480 +5
===========================================
- Hits 16554 16534 -20
- Misses 8576 8598 +22
- Partials 1345 1348 +3
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this value Hi!\n
mean ?
https://github.com/line/tendermint/pull/174/files#diff-2b6e7e0353cdd8f2400baf409cc0206c48d2ac16dbfd68457cead476444123efR15
This is cherry-picked PR, so I don't know exactly what the original author meant. |
Description
CI fails because of test relied on connecting to the external site.
So cherry-pick tendermint/tendermint#5997
And increase the
test_cover
timeoutFor contributor use:
docs/
) and code commentsFiles changed
in the Github PR explorer