Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: typos #857

Merged
merged 5 commits into from
Feb 22, 2023
Merged

chore: typos #857

merged 5 commits into from
Feb 22, 2023

Conversation

omahs
Copy link
Contributor

@omahs omahs commented Jan 5, 2023

Fix: typos

omahs added 3 commits January 5, 2023 14:51
@omahs
Fix: typos
6f06753 
Fix: typos
@omahs
Fix: typo
6fd7203 
Fix: typo
@omahs
Fix: typo
ba3060d 
Fix: typo
@CLAassistant
Copy link

CLAassistant commented Jan 5, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Jan 6, 2023 •
edited
Loading

Codecov Report

Merging #857 (58d8f82) into main (df3df2f) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #857      +/-   ##
==========================================
- Coverage   62.37%   62.32%   -0.05%     
==========================================
  Files         653      653              
  Lines       79976    79443     -533     
==========================================
- Hits        49884    49515     -369     
+ Misses      27400    27249     -151     
+ Partials     2692     2679      -13
Impacted Files Coverage Δ
client/context.go 53.93% <0.00%> (ø)
crypto/keys/secp256k1/internal/secp256k1/curve.go 42.85% <ø> (ø)
store/types/listening.go 68.42% <ø> (ø)
types/query/pagination.pb.go 37.45% <ø> (ø)
types/result.go 76.64% <ø> (-0.14%) ⬇️
x/bankplus/keeper/inactive.go 100.00% <ø> (ø)
x/bankplus/keeper/keeper.go 92.06% <0.00%> (-4.17%) ⬇️
x/genutil/client/cli/init.go 67.41% <0.00%> (-1.74%) ⬇️
simapp/simd/cmd/root.go 87.92% <0.00%> (-1.12%) ⬇️
x/token/keeper/send.go 89.18% <0.00%> (-0.94%) ⬇️
... and 44 more

tkxkd0159
tkxkd0159 previously approved these changes Jan 16, 2023
View reviewed changes
@tkxkd0159 tkxkd0159 self-requested a review January 17, 2023 01:14
@tkxkd0159
Copy link
Member

lint is broken

zemyblue
zemyblue reviewed Feb 3, 2023
View reviewed changes
client/context.go Outdated Show resolved Hide resolved
@tkxkd0159 tkxkd0159 changed the title Fix: typos fix: typos Feb 15, 2023
@tkxkd0159 tkxkd0159 changed the title fix: typos chore: typos Feb 15, 2023
@tkxkd0159 tkxkd0159 requested a review from zemyblue February 15, 2023 06:59
@zemyblue zemyblue merged commit 34c10e5 into Finschia:main Feb 22, 2023
zemyblue pushed a commit to zemyblue/finschia-sdk that referenced this pull request Mar 17, 2023
@tkxkd0159 @zemyblue
chore: typos (Finschia#857)
f3ce309 
* Fix: typos

Fix: typos

* Fix: typo

Fix: typo

* Fix: typo

Fix: typo

* go fmt

---------

Co-authored-by: Jayden Lee <[email protected]>
@jaeseung-bae jaeseung-bae mentioned this pull request Dec 26, 2023
Open
96 tasks
@170210 170210 mentioned this pull request Jan 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkxkd0159 tkxkd0159 tkxkd0159 approved these changes

@zemyblue zemyblue zemyblue approved these changes

@0Tech 0Tech Awaiting requested review from 0Tech 0Tech is a code owner

@dudong2 dudong2 Awaiting requested review from dudong2

Assignees
No one assigned
Labels
automerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@omahs @CLAassistant @tkxkd0159 @zemyblue