Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: apply foundation audit #834

Merged
merged 7 commits into from
Dec 26, 2022
Merged

fix: apply foundation audit #834

merged 7 commits into from
Dec 26, 2022

Conversation

0Tech
Copy link
Collaborator

@0Tech 0Tech commented Dec 15, 2022

Description

This patch would:

  • fix omitted invariant
  • fix unit tests and refactor them.

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@0Tech 0Tech added the C:x/foundation x/foundation module label Dec 15, 2022
@0Tech 0Tech self-assigned this Dec 15, 2022
@codecov
Copy link

codecov bot commented Dec 15, 2022

Codecov Report

Merging #834 (0c629f3) into main (16e60d2) will increase coverage by 1.38%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #834      +/-   ##
==========================================
+ Coverage   61.79%   63.17%   +1.38%     
==========================================
  Files         883      869      -14     
  Lines      100381   100426      +45     
==========================================
+ Hits        62029    63446    +1417     
+ Misses      34725    33442    -1283     
+ Partials     3627     3538      -89     
Impacted Files Coverage Δ
x/foundation/genesis.go 83.21% <100.00%> (ø)
x/foundation/keeper/invariants.go 100.00% <100.00%> (ø)
client/rpc/block.go 0.00% <0.00%> (-46.56%) ⬇️
x/token/validation.go 89.09% <0.00%> (-3.64%) ⬇️
client/rpc/validators.go 0.00% <0.00%> (-1.54%) ⬇️
types/module/module.go 67.36% <0.00%> (-0.54%) ⬇️
testutil/network/network.go 81.66% <0.00%> (-0.06%) ⬇️
x/wasm/types/types.go 57.20% <0.00%> (ø)
types/query/pagination.go 80.00% <0.00%> (ø)
x/auth/client/cli/query.go 1.92% <0.00%> (ø)
... and 42 more

@0Tech 0Tech marked this pull request as ready for review December 15, 2022 11:06
This reverts commit dba3509.
@0Tech 0Tech requested a review from zemyblue December 16, 2022 01:23
@0Tech 0Tech merged commit f26c56b into Finschia:main Dec 26, 2022
@0Tech 0Tech deleted the foundation_audit branch December 26, 2022 08:03
zemyblue added a commit to zemyblue/finschia-sdk that referenced this pull request Jan 12, 2023
* main: (30 commits)
  chore(deps): Bump actions/cache from 3.2.2 to 3.2.3 (Finschia#860)
  chore(deps): Bump golang.org/x/crypto from 0.4.0 to 0.5.0 (Finschia#854)
  feat: Remove `x/wasm` module (Finschia#850)
  refactor: Remove useless stub BeginBlock/EndBlock methods (Finschia#853)
  feat: enable querying based on mempool status (only gRPC) (Finschia#840)
  feat(x/foundation): remove unnecessary gov-mint feature (Finschia#848)
  chore(deps): Bump actions/cache from 3.2.1 to 3.2.2 (Finschia#845)
  chore(deps): Bump github.com/mattn/go-isatty from 0.0.16 to 0.0.17 (Finschia#847)
  chore(deps): Bump actions/cache from 3.2.0 to 3.2.1 (Finschia#841)
  fix: apply foundation audit (Finschia#834)
  chore(deps): Bump actions/setup-go from 3.4.0 to 3.5.0 (Finschia#831)
  chore(deps): Bump actions/cache from 3.0.11 to 3.2.0 (Finschia#839)
  ci: automate release process (Finschia#829)
  chore(deps): Bump github.com/prometheus/common from 0.37.0 to 0.39.0 (Finschia#832)
  chore(deps): Bump goreleaser/goreleaser-action from 3 to 4 (Finschia#830)
  chore(deps): Bump github.com/magiconair/properties from 1.8.6 to 1.8.7 (Finschia#826)
  chore(deps): Bump technote-space/get-diff-action from 6.1.1 to 6.1.2 (Finschia#822)
  chore(deps): Bump golang.org/x/crypto from 0.2.0 to 0.4.0 (Finschia#828)
  feat: Get validator pubkey considering KMS (Finschia#821)
  Remove support for composite (BLS) key type (Finschia#817)
  ...

# Conflicts:
#	x/foundation/msgs.go
#	x/wasm/lbmtypes/codec.go
#	x/wasm/types/codec.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:x/foundation x/foundation module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants