Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Amino Codec Registration #736

Merged
merged 8 commits into from
Oct 19, 2022
Merged

Conversation

zemyblue
Copy link
Member

@zemyblue zemyblue commented Oct 18, 2022

Description

This PR applys the missing amino codec registration PRs of cosmos-sdk.
I'll add token, collection and foundation amino codec as another pr.

related: #735

I want to merge this PR as commit merge style, since this sub pr is cosmos-sdk pr and we need to keep the commit history.

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

RiccardoM and others added 6 commits October 18, 2022 22:12
…-sdk #11224)

* fix: Add RegisterLegacyAminoCodec for authz/feegrant

* add module name

* Fix GetSignByes, add tests

* removed module names from registered messages to match other modules

* added interfaces and concrete types registration

* unseal amino instances to allow external grant and authorization registration

* fixed messages tests

* allow to register external types into authz modulecdc

* use legacy.Cdc instead of ModuleCdc inside x/authz

* move the legacy.Cdc initialization outside init function

* added serialization docs

* Update docs/core/encoding.md

Co-authored-by: Amaury <[email protected]>

* added the Ledger specification

* fixed tests

Co-authored-by: Amaury M <[email protected]>
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 4 committers have signed the CLA.

✅ zemyblue
❌ RiccardoM
❌ amaurym
❌ blushi
You have signed the CLA already but the status is still pending? Let us recheck it.

@zemyblue zemyblue self-assigned this Oct 18, 2022
@codecov
Copy link

codecov bot commented Oct 18, 2022

Codecov Report

Merging #736 (3dafa5c) into main (b13ab12) will increase coverage by 0.06%.
The diff coverage is 96.75%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #736      +/-   ##
==========================================
+ Coverage   61.95%   62.02%   +0.06%     
==========================================
  Files         875      877       +2     
  Lines       98798    98890      +92     
==========================================
+ Hits        61210    61334     +124     
+ Misses      33985    33942      -43     
- Partials     3603     3614      +11     
Impacted Files Coverage Δ
x/auth/vesting/types/msgs.go 0.00% <0.00%> (ø)
x/distribution/types/proposal.go 6.89% <ø> (-3.11%) ⬇️
x/params/types/proposal/proposal.go 43.13% <ø> (-1.10%) ⬇️
x/upgrade/types/proposal.go 78.78% <ø> (-1.22%) ⬇️
x/wasm/lbmtypes/proposal.go 8.82% <ø> (-5.07%) ⬇️
x/wasm/types/proposal.go 64.07% <ø> (-0.94%) ⬇️
x/authz/keeper/keeper.go 68.48% <33.33%> (-0.23%) ⬇️
x/gov/types/msgs.go 50.32% <83.33%> (ø)
codec/legacy/amino_msg.go 100.00% <100.00%> (ø)
codec/legacy/codec.go 40.00% <100.00%> (ø)
... and 27 more

@zemyblue zemyblue requested review from dudong2, ulbqb and 0Tech October 19, 2022 01:48
@ulbqb
Copy link
Member

ulbqb commented Oct 19, 2022

ibc and stakingplus need to support this issue?

@zemyblue
Copy link
Member Author

ibc and stakingplus need to support this issue?

Thank you for notify to me. I'll apply it as next PR.

Copy link
Collaborator

@0Tech 0Tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Register legacy amino codec for support the ledger device
7 participants