-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing Amino Codec Registration #736
Conversation
…-sdk #11224) * fix: Add RegisterLegacyAminoCodec for authz/feegrant * add module name * Fix GetSignByes, add tests * removed module names from registered messages to match other modules * added interfaces and concrete types registration * unseal amino instances to allow external grant and authorization registration * fixed messages tests * allow to register external types into authz modulecdc * use legacy.Cdc instead of ModuleCdc inside x/authz * move the legacy.Cdc initialization outside init function * added serialization docs * Update docs/core/encoding.md Co-authored-by: Amaury <[email protected]> * added the Ledger specification * fixed tests Co-authored-by: Amaury M <[email protected]>
Signed-off-by: zemyblue <[email protected]>
…240) Signed-off-by: zemyblue <[email protected]>
…cosmos-sdk #11349)
…11680) Signed-off-by: zemyblue <[email protected]>
Signed-off-by: zemyblue <[email protected]>
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #736 +/- ##
==========================================
+ Coverage 61.95% 62.02% +0.06%
==========================================
Files 875 877 +2
Lines 98798 98890 +92
==========================================
+ Hits 61210 61334 +124
+ Misses 33985 33942 -43
- Partials 3603 3614 +11
|
Signed-off-by: zemyblue <[email protected]>
|
Thank you for notify to me. I'll apply it as next PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This PR applys the missing amino codec registration PRs of cosmos-sdk.
I'll add
token
,collection
andfoundation
amino codec as another pr.related: #735
I want to merge this PR as
commit merge
style, since this sub pr is cosmos-sdk pr and we need to keep the commit history.Motivation and context
How has this been tested?
Screenshots (if appropriate):
Checklist:
CHANGELOG.md
client/docs/swagger-ui/swagger.yaml