Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove VRFProve #731

Merged
merged 4 commits into from
Oct 19, 2022
Merged

fix: remove VRFProve #731

merged 4 commits into from
Oct 19, 2022

Conversation

ulbqb
Copy link
Member

@ulbqb ulbqb commented Oct 18, 2022

Description

VRFProve() function was incorrect implementation and unnecessary. So, I removed VRFProve() function.

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@codecov
Copy link

codecov bot commented Oct 18, 2022

Codecov Report

Merging #731 (303cea5) into main (5ed82db) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #731      +/-   ##
==========================================
- Coverage   61.96%   61.95%   -0.02%     
==========================================
  Files         877      877              
  Lines       98764    98762       -2     
==========================================
- Hits        61200    61185      -15     
- Misses      33955    33960       +5     
- Partials     3609     3617       +8     
Impacted Files Coverage Δ
crypto/ledger/ledger_secp256k1.go 52.89% <ø> (+0.75%) ⬆️
x/token/validation.go 72.72% <0.00%> (-18.19%) ⬇️
x/collection/msgs.go 41.29% <0.00%> (-1.67%) ⬇️
x/token/msgs.go 34.51% <0.00%> (+2.03%) ⬆️

@ulbqb ulbqb marked this pull request as ready for review October 18, 2022 07:40
@ulbqb ulbqb requested review from tnasu and zemyblue October 18, 2022 07:41
@ulbqb ulbqb self-assigned this Oct 18, 2022
@ulbqb ulbqb requested a review from 0Tech October 19, 2022 03:01
@ulbqb ulbqb merged commit 77fc5ce into Finschia:main Oct 19, 2022
@ulbqb ulbqb deleted the fix/vrfprove branch October 19, 2022 05:20
@zemyblue zemyblue mentioned this pull request Oct 27, 2022
5 tasks
@zemyblue zemyblue mentioned this pull request Nov 28, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants