Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add missing blockedAddr checking in bankplus #705

Merged
merged 4 commits into from
Oct 12, 2022

Conversation

zemyblue
Copy link
Member

@zemyblue zemyblue commented Oct 11, 2022

Description

closes: #667

Add missing blockedAddr checking feature in bankplug module.
Thank you. @ulbqb

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@zemyblue zemyblue self-assigned this Oct 11, 2022
@codecov
Copy link

codecov bot commented Oct 11, 2022

Codecov Report

Merging #705 (829cec0) into main (1a3eabd) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #705      +/-   ##
==========================================
+ Coverage   61.18%   61.22%   +0.03%     
==========================================
  Files         873      874       +1     
  Lines       98501    98549      +48     
==========================================
+ Hits        60265    60333      +68     
+ Misses      34667    34654      -13     
+ Partials     3569     3562       -7     
Impacted Files Coverage Δ
x/bankplus/keeper/keeper.go 96.22% <100.00%> (+0.22%) ⬆️
x/token/token.go 50.00% <0.00%> (-50.00%) ⬇️
x/token/validation.go 65.45% <0.00%> (-3.64%) ⬇️
x/token/msgs.go 30.45% <0.00%> (ø)
x/wasm/client/cli/tx.go 16.10% <0.00%> (ø)
internal/os/file.go 76.19% <0.00%> (ø)
x/ibc/applications/transfer/keeper/relay.go 88.15% <0.00%> (+1.04%) ⬆️
x/collection/msgs.go 42.03% <0.00%> (+5.37%) ⬆️
x/wasm/lbmtypes/tx.go 61.76% <0.00%> (+8.82%) ⬆️
x/distribution/client/cli/utils.go 57.14% <0.00%> (+11.68%) ⬆️

@zemyblue zemyblue requested review from ulbqb, 0Tech, dudong2 and tnasu October 11, 2022 10:37
@zemyblue zemyblue merged commit 9ef6557 into Finschia:main Oct 12, 2022
@zemyblue zemyblue deleted the feat/issue_667 branch October 19, 2022 02:52
@zemyblue zemyblue mentioned this pull request Oct 27, 2022
5 tasks
@zemyblue zemyblue mentioned this pull request Nov 28, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bankplus module is not extension of bank module
3 participants