Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove MinThreshold and MinPercentage from x/foundation config #686

Merged
merged 3 commits into from
Sep 29, 2022

Conversation

0Tech
Copy link
Collaborator

@0Tech 0Tech commented Sep 28, 2022

Description

Remove the minimum boundary of the policies:

  • MinThreshold
  • MinPercentage

Motivation and context

After this patch is applied, we could out-source the proposal relevant logic to x/group later.

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@0Tech 0Tech self-assigned this Sep 28, 2022
@codecov
Copy link

codecov bot commented Sep 28, 2022

Codecov Report

Merging #686 (a54bf5a) into main (47eeccc) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #686      +/-   ##
==========================================
+ Coverage   61.01%   61.04%   +0.03%     
==========================================
  Files         873      873              
  Lines       98429    98421       -8     
==========================================
+ Hits        60054    60082      +28     
+ Misses      34787    34734      -53     
- Partials     3588     3605      +17     
Impacted Files Coverage Δ
x/foundation/config.go 100.00% <ø> (ø)
x/foundation/foundation.go 76.75% <100.00%> (+0.94%) ⬆️
x/foundation/keeper/genesis.go 80.51% <100.00%> (ø)
x/collection/msgs.go 41.48% <0.00%> (+3.14%) ⬆️
x/foundation/msgs.go 43.26% <0.00%> (+3.36%) ⬆️
x/token/msgs.go 34.51% <0.00%> (+4.06%) ⬆️

@0Tech 0Tech requested review from dudong2 and zemyblue September 28, 2022 13:27
@0Tech 0Tech marked this pull request as ready for review September 28, 2022 15:23
CHANGELOG.md Outdated Show resolved Hide resolved
x/foundation/foundation.go Show resolved Hide resolved
@0Tech 0Tech requested a review from zemyblue September 29, 2022 02:26
@0Tech 0Tech merged commit d62f0c9 into Finschia:main Sep 29, 2022
@0Tech 0Tech deleted the foundation_config branch September 29, 2022 04:44
@zemyblue zemyblue added the C:x/foundation x/foundation module label Oct 24, 2022
@zemyblue zemyblue mentioned this pull request Oct 27, 2022
5 tasks
@zemyblue zemyblue mentioned this pull request Nov 28, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:x/foundation x/foundation module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants