Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add x/wasm module to simapp #591

Merged
merged 7 commits into from
Jul 15, 2022

Conversation

zemyblue
Copy link
Member

@zemyblue zemyblue commented Jul 11, 2022

Description

Add x/wasm module to simapp of lbm-sdk default app.
And DockerFile also fixed to build cosmwasm library for x/wasm module.

closes: #557

Motivation and context

default simapp of lbm-sdk doesn't have wasm feature

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@zemyblue zemyblue mentioned this pull request Jul 11, 2022
5 tasks
@zemyblue zemyblue self-assigned this Jul 11, 2022
@codecov
Copy link

codecov bot commented Jul 12, 2022

Codecov Report

Merging #591 (83cde88) into main (fa0dc25) will increase coverage by 0.01%.
The diff coverage is 81.48%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #591      +/-   ##
==========================================
+ Coverage   57.55%   57.57%   +0.01%     
==========================================
  Files         796      796              
  Lines       87814    87863      +49     
==========================================
+ Hits        50543    50584      +41     
- Misses      34100    34105       +5     
- Partials     3171     3174       +3     
Impacted Files Coverage Δ
x/auth/client/testutil/suite.go 96.42% <0.00%> (ø)
simapp/simd/cmd/root.go 80.85% <28.57%> (-0.89%) ⬇️
simapp/app.go 87.67% <90.90%> (+0.29%) ⬆️
simapp/test_helpers.go 6.70% <100.00%> (ø)
testutil/network/network.go 81.71% <100.00%> (+0.05%) ⬆️
crypto/keys/internal/ecdsa/privkey.go 82.45% <0.00%> (-1.76%) ⬇️

simapp/simd/cmd/root.go Show resolved Hide resolved
Dockerfile Show resolved Hide resolved
@zemyblue zemyblue merged commit f46f02b into Finschia:main Jul 15, 2022
@zemyblue zemyblue mentioned this pull request Oct 27, 2022
5 tasks
@zemyblue zemyblue mentioned this pull request Nov 28, 2022
5 tasks
@zemyblue zemyblue deleted the add_wasm_to_simapp branch December 22, 2022 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

simapp does not support M1
4 participants