Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add x/collection proto #571

Merged
merged 20 commits into from
Jul 18, 2022
Merged

feat: add x/collection proto #571

merged 20 commits into from
Jul 18, 2022

Conversation

0Tech
Copy link
Collaborator

@0Tech 0Tech commented Jun 23, 2022 •
edited
Loading

Description

ref: #487

Motivation and context

Before adding the entire implementation of x/collection, I upload its proto first for the review.

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes. [no need]
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@0Tech 0Tech self-assigned this Jun 23, 2022
@0Tech 0Tech requested review from dudong2 and zemyblue June 23, 2022 13:01
@0Tech 0Tech marked this pull request as ready for review June 23, 2022 13:01
@0Tech 0Tech requested a review from ByunghyunBang July 13, 2022 09:51
@0Tech
Copy link
Collaborator Author

0Tech commented Jul 15, 2022

@ByunghyunBang If there is no more issue, please approve this PR. It's blocking #574.

@codecov
Copy link

codecov bot commented Jul 18, 2022

Codecov Report

Merging #571 (b05ba1e) into main (c6f7293) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #571      +/-   ##
==========================================
- Coverage   57.55%   57.55%   -0.01%     
==========================================
  Files         797      797              
  Lines       87593    87593              
==========================================
- Hits        50416    50413       -3     
- Misses      34035    34037       +2     
- Partials     3142     3143       +1
Impacted Files Coverage Δ
x/wasm/keeper/keeper.go 85.85% <0.00%> (-0.36%) ⬇️

@0Tech 0Tech merged commit 6331b66 into Finschia:main Jul 18, 2022
@0Tech 0Tech deleted the collection_proto branch July 18, 2022 07:14
@zemyblue zemyblue mentioned this pull request Oct 27, 2022
Merged
5 tasks
@zemyblue zemyblue mentioned this pull request Nov 28, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ByunghyunBang ByunghyunBang ByunghyunBang approved these changes

@dudong2 dudong2 dudong2 approved these changes

@zemyblue zemyblue zemyblue approved these changes

Assignees

@0Tech 0Tech

Labels
C:x/collection
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@0Tech @zemyblue @dudong2 @ByunghyunBang