-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: move SigBlockHeight from TxBody into AuthInfo #344
Conversation
Codecov Report
@@ Coverage Diff @@
## main #344 +/- ##
=======================================
Coverage ? 53.17%
=======================================
Files ? 642
Lines ? 67251
Branches ? 0
=======================================
Hits ? 35761
Misses ? 28547
Partials ? 2943 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congratulations on your first PR.
I have left a minor comment, but it's LGTM.
And how about changing the title of this PR starting feat
rather than fix
?
This PR contains changes that required consumer actions.
Description
closes: #293
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes