Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move SigBlockHeight from TxBody into AuthInfo #344

Merged
merged 6 commits into from
Oct 5, 2021

Conversation

0Tech
Copy link
Collaborator

@0Tech 0Tech commented Oct 5, 2021

Description

closes: #293


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@CLAassistant
Copy link

CLAassistant commented Oct 5, 2021

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Oct 5, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@81bdb22). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #344   +/-   ##
=======================================
  Coverage        ?   53.17%           
=======================================
  Files           ?      642           
  Lines           ?    67251           
  Branches        ?        0           
=======================================
  Hits            ?    35761           
  Misses          ?    28547           
  Partials        ?     2943           

@0Tech 0Tech added the A: improvement Changes in existing functionality label Oct 5, 2021
@0Tech 0Tech self-assigned this Oct 5, 2021
CHANGELOG.md Outdated Show resolved Hide resolved
@0Tech 0Tech requested review from iproudhon and dudong2 October 5, 2021 07:56
Copy link

@egonspace egonspace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@egonspace egonspace requested a review from whylee259 October 5, 2021 08:48
Copy link
Contributor

@whylee259 whylee259 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations on your first PR.
I have left a minor comment, but it's LGTM.
And how about changing the title of this PR starting feat rather than fix?
This PR contains changes that required consumer actions.

CHANGELOG.md Outdated Show resolved Hide resolved
@0Tech 0Tech changed the title fix: move SigBlockHeight from TxBody into AuthInfo feat: move SigBlockHeight from TxBody into AuthInfo Oct 5, 2021
@egonspace egonspace changed the title feat: move SigBlockHeight from TxBody into AuthInfo fix: move SigBlockHeight from TxBody into AuthInfo Oct 5, 2021
@egonspace egonspace merged commit cc78696 into Finschia:main Oct 5, 2021
@0Tech 0Tech deleted the 0Tech/fix/sig_block_height branch October 6, 2021 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: improvement Changes in existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is it appropriate for sig_block_height to be included in the tx_body?
4 participants