fix: return error instead of panic for behaviors triggered by client #1395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkxkd0159
changed the title
tkxkd0159
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1395 +/- ##
=======================================
Coverage 69.68% 69.69%
=======================================
Files 668 668
Lines 56242 56242
=======================================
+ Hits 39194 39198 +4
+ Misses 14775 14773 -2
+ Partials 2273 2271 -2
|
0Tech
reviewed
May 24, 2024
There was a problem hiding this comment.
It could be nice to address other panics on x/fbridge. I found 2 points:
- critical
- keeper/abci.go#L36: In theory,
updateRole()can return error by registering two identical role suggestions. So we have to update the error handling or the chain halts.
- keeper/abci.go#L36: In theory,
- good-to-have
- keeper/genesis.go#L22 and L28:
setRole()andsetBridgeSwitch()may return error because of its argument verification. It that case,InitGenesis()panics, instead of returning errors. However, ifInitGenesis()returns any errors, eventually it will panic by the module. Hence, it would be good to return errors or modify the signature ofInitGenesis()so it won't return any errors.
- keeper/genesis.go#L22 and L28:
tkxkd0159
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1395 +/- ##
==========================================
+ Coverage 69.68% 70.02% +0.33%
==========================================
Files 668 672 +4
Lines 56242 56866 +624
==========================================
+ Hits 39194 39818 +624
Misses 14775 14775
Partials 2273 2273
|
0Tech
reviewed
May 24, 2024
0Tech
previously approved these changes
May 24, 2024
0Tech
reviewed
May 24, 2024
0Tech
approved these changes
May 24, 2024
jaeseung-bae
approved these changes
May 24, 2024
5 tasks
zemyblue
pushed a commit
that referenced
this pull request
May 24, 2024
…1395) (#1400) (cherry picked from commit 6c90f1e) Co-authored-by: Jeseung Lee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #XXXX
Motivation and context
How has this been tested?
Screenshots (if appropriate):
Checklist:
CHANGELOG.mdclient/docs/swagger-ui/swagger.yaml