Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where amino is not supported in fswap and fbridge #1378

Merged
merged 5 commits into from
May 13, 2024

Conversation

zemyblue
Copy link
Member

@zemyblue zemyblue commented May 11, 2024

Description

  • Fix bug where amino is not supported in fswap and fbridge

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@zemyblue zemyblue changed the title Fixed issue where amino is not supported in fswap and fbridge Fixed bug where amino is not supported in fswap and fbridge May 11, 2024
@zemyblue zemyblue changed the title Fixed bug where amino is not supported in fswap and fbridge Fix bug where amino is not supported in fswap and fbridge May 11, 2024
@zemyblue zemyblue added backport/v0.49.x A: bug Something isn't working labels May 11, 2024
@zemyblue zemyblue marked this pull request as ready for review May 11, 2024 09:25
@zemyblue zemyblue self-assigned this May 11, 2024
Copy link

codecov bot commented May 11, 2024

Codecov Report

Attention: Patch coverage is 96.61017% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 69.58%. Comparing base (97570b2) to head (559fabd).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1378      +/-   ##
==========================================
+ Coverage   69.50%   69.58%   +0.08%     
==========================================
  Files         668      668              
  Lines       56149    56208      +59     
==========================================
+ Hits        39025    39111      +86     
+ Misses      14857    14830      -27     
  Partials     2267     2267              
Files Coverage Δ
x/fbridge/types/codec.go 55.55% <100.00%> (+1.26%) ⬆️
x/fbridge/types/keys.go 0.00% <ø> (ø)
x/fbridge/types/msgs.go 66.66% <100.00%> (+66.66%) ⬆️
x/fswap/types/msgs.go 28.57% <85.71%> (+28.57%) ⬆️

... and 1 file with indirect coverage changes

Copy link
Collaborator

@0Tech 0Tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Making the messages support LegacyMsg would be sufficient, so others are redundant. But it should be OK.

@zemyblue zemyblue merged commit ed74ee8 into Finschia:main May 13, 2024
38 checks passed
@zemyblue zemyblue deleted the feat/fswap_fbridge_amino branch May 13, 2024 01:42
mergify bot pushed a commit that referenced this pull request May 13, 2024
* fix: does not support fswap and fbridge amino bug

* chore: update swagger for fbridge

* chore: update changelog

* chore: add unittest for amino msg.

* chore: add unittest for amino msg.

(cherry picked from commit ed74ee8)

# Conflicts:
#	client/docs/swagger-ui/swagger.yaml
zemyblue added a commit that referenced this pull request May 13, 2024
…1378) (#1380)

* Fix bug where amino is not supported in fswap and fbridge (#1378)

* fix: does not support fswap and fbridge amino bug

* chore: update swagger for fbridge

* chore: update changelog

* chore: add unittest for amino msg.

* chore: add unittest for amino msg.

(cherry picked from commit ed74ee8)

# Conflicts:
#	client/docs/swagger-ui/swagger.yaml

* fix conflicts

* Revert "fix conflicts"

This reverts commit f896ddc.

* fix conflicts

---------

Co-authored-by: zemyblue <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: bug Something isn't working backport/v0.49.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants