-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug where amino is not supported in fswap and fbridge #1378
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1378 +/- ##
==========================================
+ Coverage 69.50% 69.58% +0.08%
==========================================
Files 668 668
Lines 56149 56208 +59
==========================================
+ Hits 39025 39111 +86
+ Misses 14857 14830 -27
Partials 2267 2267
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Making the messages support LegacyMsg would be sufficient, so others are redundant. But it should be OK.
* fix: does not support fswap and fbridge amino bug * chore: update swagger for fbridge * chore: update changelog * chore: add unittest for amino msg. * chore: add unittest for amino msg. (cherry picked from commit ed74ee8) # Conflicts: # client/docs/swagger-ui/swagger.yaml
…1378) (#1380) * Fix bug where amino is not supported in fswap and fbridge (#1378) * fix: does not support fswap and fbridge amino bug * chore: update swagger for fbridge * chore: update changelog * chore: add unittest for amino msg. * chore: add unittest for amino msg. (cherry picked from commit ed74ee8) # Conflicts: # client/docs/swagger-ui/swagger.yaml * fix conflicts * Revert "fix conflicts" This reverts commit f896ddc. * fix conflicts --------- Co-authored-by: zemyblue <[email protected]>
Description
Motivation and context
How has this been tested?
Screenshots (if appropriate):
Checklist:
CHANGELOG.md
client/docs/swagger-ui/swagger.yaml