Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: replace IsEqual with Equal #1314

Merged
merged 2 commits into from
Mar 27, 2024
Merged

fix: replace IsEqual with Equal #1314

merged 2 commits into from
Mar 27, 2024

Conversation

ulbqb
Copy link
Member

@ulbqb ulbqb commented Mar 27, 2024 •
edited
Loading

Description

closes: #XXXX

cherry-pick: cosmos/cosmos-sdk#14739

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@codecov Codecov
Copy link

codecov bot commented Mar 27, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 65.00000% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 70.41%. Comparing base (05ff4ea) to head (7b7c491).
Report is 1 commits behind head on main.

❗ Current head 7b7c491 differs from pull request most recent head 5cebd5f. Consider uploading reports for the commit 5cebd5f to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1314      +/-   ##
==========================================
- Coverage   70.41%   70.41%   -0.01%     
==========================================
  Files         643      643              
  Lines       54758    54754       -4     
==========================================
- Hits        38560    38555       -5     
- Misses      14023    14025       +2     
+ Partials     2175     2174       -1
Files Coverage Δ
types/coin.go 94.69% <100.00%> (-0.03%) ⬇️
x/auth/vesting/types/vesting_account.go 86.82% <100.00%> (ø)
x/bank/keeper/genesis.go 84.00% <100.00%> (ø)
x/bank/keeper/invariants.go 61.53% <100.00%> (ø)
x/bank/types/msgs.go 97.50% <100.00%> (ø)
x/distribution/keeper/invariants.go 54.63% <100.00%> (ø)
x/foundation/keeper/internal/invariants.go 100.00% <100.00%> (ø)
x/gov/types/params.go 7.05% <100.00%> (ø)
x/staking/genesis.go 58.86% <100.00%> (ø)
simapp/test_helpers.go 10.37% <0.00%> (ø)
... and 5 more

... and 1 file with indirect coverage changes

@ulbqb ulbqb changed the title Replace IsEqual with Equal fix: Replace IsEqual with Equal Mar 27, 2024
@ulbqb ulbqb changed the title fix: Replace IsEqual with Equal fix: replace IsEqual with Equal Mar 27, 2024
@ulbqb ulbqb self-assigned this Mar 27, 2024
@ulbqb
Copy link
Member Author

ulbqb commented Mar 27, 2024 •
edited
Loading

Can I ignore code cov failure? This is about deprecated function.

@ulbqb ulbqb marked this pull request as ready for review March 27, 2024 09:22
@ulbqb ulbqb requested a review from 170210 March 27, 2024 09:22
@jaeseung-bae
Copy link
Contributor

jaeseung-bae commented Mar 27, 2024 •
edited
Loading

Please put proper labels.

@ulbqb ulbqb removed the C:x/mint label Mar 27, 2024
@ulbqb ulbqb merged commit 143a763 into Finschia:main Mar 27, 2024
81 checks passed
@ulbqb ulbqb deleted the fix/COI-02 branch March 27, 2024 10:28
mergify bot pushed a commit that referenced this pull request Mar 27, 2024
@ulbqb @mergify
fix: replace IsEqual with Equal (#1314)
124ef10 
* Replace IsEqual with Equal

* Update CHANGELOG

(cherry picked from commit 143a763)

# Conflicts:
#	CHANGELOG.md
@mergify mergify bot mentioned this pull request Mar 27, 2024
Merged
5 tasks
0Tech added a commit that referenced this pull request Mar 29, 2024
@mergify @ulbqb @0Tech
fix: replace IsEqual with Equal (backport #1314) (#1317)
581d50c 
* fix: replace IsEqual with Equal (#1314)

* Replace IsEqual with Equal

* Update CHANGELOG

(cherry picked from commit 143a763)

# Conflicts:
#	CHANGELOG.md

* Update CHANGELOG.md

---------

Co-authored-by: Shogo Hyodo <[email protected]>
Co-authored-by: Youngtaek Yoon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@170210 170210 170210 approved these changes

@tkxkd0159 tkxkd0159 tkxkd0159 approved these changes

@zemyblue zemyblue Awaiting requested review from zemyblue zemyblue is a code owner

@0Tech 0Tech Awaiting requested review from 0Tech 0Tech is a code owner

@jaeseung-bae jaeseung-bae Awaiting requested review from jaeseung-bae

Assignees

@ulbqb ulbqb

Labels
A: bug Something isn't working backport/v0.48.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ulbqb @jaeseung-bae @tkxkd0159 @170210