-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ignore error when key not found in keys delete #1312
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1312 +/- ##
==========================================
- Coverage 70.41% 70.41% -0.01%
==========================================
Files 643 643
Lines 54758 54759 +1
==========================================
Hits 38560 38560
- Misses 14023 14024 +1
Partials 2175 2175
|
Signed-off-by: 170210 <[email protected]>
* fix(client/keys): don't return when key not found in keys delete (#18562) * chore: update CHANGLOG.md Signed-off-by: 170210 <[email protected]> --------- Signed-off-by: 170210 <[email protected]> Co-authored-by: Julián Toledano <[email protected]> (cherry picked from commit e5709f3) # Conflicts: # CHANGELOG.md
…1315) * fix: ignore error when key not found in keys delete (#1312) * fix(client/keys): don't return when key not found in keys delete (#18562) * chore: update CHANGLOG.md Signed-off-by: 170210 <[email protected]> --------- Signed-off-by: 170210 <[email protected]> Co-authored-by: Julián Toledano <[email protected]> (cherry picked from commit e5709f3) # Conflicts: # CHANGELOG.md * Update CHANGELOG.md --------- Co-authored-by: 170210 <[email protected]> Co-authored-by: Youngtaek Yoon <[email protected]>
Description
If you provide a list of keys to the keys delete command, it will stop and fail if one of those keys is not found.
This pr cherry-pick the following pr:
Motivation and context
How has this been tested?
Screenshots (if appropriate):
Checklist:
CHANGELOG.md
client/docs/swagger-ui/swagger.yaml