Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(collection): add more verify logics for tests(SendFT, OperatorSendFT, Authorize, Revoke) #1133

Merged
merged 6 commits into from
Oct 12, 2023
Merged

test(collection): add more verify logics for tests(SendFT, OperatorSendFT, Authorize, Revoke) #1133

merged 6 commits into from
Oct 12, 2023

Conversation

jaeseung-bae
Copy link
Contributor

@jaeseung-bae jaeseung-bae commented Oct 4, 2023 •
edited
Loading

Description

  • This PR refactors tests for SendFT, OperatorSendFT, AuthorizeOperator, and RevokeOperator to check more states

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@codecov
Copy link

codecov bot commented Oct 4, 2023 •
edited
Loading

Codecov Report

Merging #1133 (fe3c74a) into rc/v0.48.0-rcx (1519bae) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##           rc/v0.48.0-rcx    #1133      +/-   ##
==================================================
- Coverage           69.77%   69.77%   -0.01%     
==================================================
  Files                 645      645              
  Lines               67482    67482              
==================================================
- Hits                47087    47086       -1     
- Misses              18209    18210       +1     
  Partials             2186     2186

see 1 file with indirect coverage changes

@jaeseung-bae jaeseung-bae self-assigned this Oct 4, 2023
@jaeseung-bae jaeseung-bae marked this pull request as ready for review October 4, 2023 23:25
zemyblue
zemyblue reviewed Oct 5, 2023
View reviewed changes
Copy link
Member

@zemyblue zemyblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any other more test cases according decision table?

@jaeseung-bae
Copy link
Contributor Author

jaeseung-bae commented Oct 6, 2023 •
edited
Loading

Are there any other more test cases according decision table?

No more tests found. This only enhances tests by verifying more states.

zemyblue
zemyblue previously approved these changes Oct 6, 2023
View reviewed changes
@jaeseung-bae jaeseung-bae requested a review from 0Tech October 10, 2023 01:50
@jaeseung-bae jaeseung-bae requested a review from 0Tech October 11, 2023 02:07
@0Tech 0Tech self-requested a review October 12, 2023 02:23
@jaeseung-bae jaeseung-bae merged commit 44c406b into Finschia:rc/v0.48.0-rcx Oct 12, 2023
36 checks passed
@jaeseung-bae jaeseung-bae deleted the test/collection branch October 12, 2023 04:15
@zemyblue zemyblue mentioned this pull request Oct 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0Tech 0Tech 0Tech approved these changes

@zemyblue zemyblue zemyblue approved these changes

@tkxkd0159 tkxkd0159 Awaiting requested review from tkxkd0159

Assignees

@jaeseung-bae jaeseung-bae

Labels
C:x/collection
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaeseung-bae @zemyblue @0Tech