Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: address generation of the empty coins in x/foundation (backport #952) #1072

Merged
merged 2 commits into from
Aug 16, 2023

Conversation

0Tech
Copy link
Collaborator

@0Tech 0Tech commented Aug 9, 2023

Description

closes: #XXXX

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@0Tech 0Tech added the C:x/foundation x/foundation module label Aug 9, 2023
@0Tech 0Tech self-assigned this Aug 9, 2023
@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Merging #1072 (5021ce8) into rc/v0.48.0-rcx (2d437b0) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           rc/v0.48.0-rcx    #1072   +/-   ##
===============================================
  Coverage           62.02%   62.02%           
===============================================
  Files                 656      656           
  Lines               78937    78941    +4     
===============================================
+ Hits                48962    48966    +4     
  Misses              27286    27286           
  Partials             2689     2689           
Files Changed Coverage Δ
x/foundation/keeper/internal/treasury.go 94.11% <100.00%> (+0.50%) ⬆️

@0Tech 0Tech changed the base branch from main to rc/v0.48.0-rcx August 9, 2023 02:12
@0Tech 0Tech marked this pull request as ready for review August 10, 2023 00:55
@0Tech 0Tech requested review from zemyblue and jaeseung-bae August 11, 2023 03:01
@zemyblue zemyblue added this to the v0.48.0 milestone Aug 16, 2023
@0Tech 0Tech merged commit 6bf0b53 into Finschia:rc/v0.48.0-rcx Aug 16, 2023
@0Tech 0Tech deleted the foundation-abci-event branch August 16, 2023 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:x/foundation x/foundation module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants