feat: bump up cosmwasm from v1.1.9 to v1.4.0 #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DefaultHasher is part of std module and is not available on no_std builds. Remove dependency on that type to pave the path for no_std support. This is done by adding test_utils::check_hash_impl helper function which tests whether type implements Hash trait. That function uses crc32fast::Hasher instead of DefaultHasher thus eliminating need for std. Furthermore, Binary and HexBinary tests checking AsRef implementation call AsRef::as_ref directly and explicitly check the result rather than unnecessarily hashing the data. As an added bonus, this diff has negative delta. \o/
cosmwasm_std: remove dependency on DefaultHasher in tests
To make it easier to implement no_std in cosmwasm_std prefer core and alloc modules over std module. std remains used - for std::backtrace module when backtraces feature is enabled, - for std::panic::set_hook if abort feature is enabled, - in testing::mock module for HashMap and - in tests. Furthermore, std is forced by some of the dependencies. Those cases will be dealt with in another change which will add default std feature.
Query Response Constructors
cosmwasm_std: prefer core and alloc modules to prepare for no_std
Checking whether a type can be used with a HashSet doesn’t actually need to involve using the HashSet. It’s sufficient to check Eq and Hash traits implementations. Simplify the tests by extending assert_hash_works macro to also test Eq trait. This also helps with eventual no_std support since there’ll be less need for conditional compilation.
Merge `release/1.3` into `main`
Co-authored-by: Mauro Lacy <[email protected]>
Co-authored-by: Christoph Otter <[email protected]>
because package `clap_lex v0.6.0` cannot be built
because the old wat expression cannot be used in wat v1.0.78 used by finschia/cosmwasm
because cosmwasm-storage is deprecated See: CosmWasm/cosmwasm@097593e, CosmWasm/cosmwasm@336ce91
Kynea0b
approved these changes
Dec 1, 2023
|
It seems that many links are linking to Cosmos, starting with: |
Only cosmwasm-vm was at 1.70.0, so standardized 1.70.0
loloicci
reviewed
Dec 6, 2023
loloicci
reviewed
Dec 7, 2023
loloicci
approved these changes
Dec 7, 2023
170210
approved these changes
Dec 7, 2023
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adopted Cosmwasm/cosmwasm v1.4.0 to Finschia/cosmwasm.
This changes the base version of Finschia/cosmwasm from
v1.1.9tov1.4.0.The test involving cosmwasm, wasmvm, and wasmd has not been done yet, so we will first merge into
feat/bump_1.4.0. Once the test with all components working together is successful, will merge intomain.Version bump as follows
Main changes
new_native_with_env->new_typed_with_env1.67.01.70.0.Types of changes
Checklist