Set line offset #23
Merged
Set line offset #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commands moved to all modes: * set_line_offset * set_inverted * display_all_points
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #21.
First commit simply sets the line offset to 0 manually in
reset().Second commit conservatively exposes some commands to all modes. I left the commands most likely to cause issues if misused in raw mode. Now available in all modes:
set_line_offsetset_inverteddisplay_all_pointsThe first commit is semver compatible, the second commit technically isn't (but only to people who somehow obtained an
St7565without callingnew()). Feel free to merge as much as you feel comfortable with.