fix(client): only call .close() when needed (#561)

Finch-API · Jan 7, 2025 · 679e438 · 679e438
1 parent 10436fd
commit 679e438
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/src/finch/_base_client.py b/src/finch/_base_client.py
@@ -768,6 +768,9 @@ def __init__(self, **kwargs: Any) -> None:
 
 class SyncHttpxClientWrapper(DefaultHttpxClient):
     def __del__(self) -> None:
+        if self.is_closed:
+            return
+
         try:
             self.close()
         except Exception:
@@ -1349,6 +1352,9 @@ def __init__(self, **kwargs: Any) -> None:
 
 class AsyncHttpxClientWrapper(DefaultAsyncHttpxClient):
     def __del__(self) -> None:
+        if self.is_closed:
+            return
+
         try:
             # TODO(someday): support non asyncio runtimes here
             asyncio.get_running_loop().create_task(self.aclose())