This repository has been archived by the owner on Mar 14, 2022. It is now read-only.
Swapping scss-lint for sass-lint to drop ruby dependency #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just tried running this locally, works fine, but the error output of |
onishiweb
approved these changes
Nov 14, 2016
added 2 commits
November 16, 2016 14:19
…ls into no-ruby * 'master' of github.com:Financial-Times/origami-build-tools: Fix url Update README.md Update README.md Add a migration guide Stop polyfills from being included via OBT 5.5.5 fix semver ranges for engines field 5.5.4 State that newer versions of node and npm are supported
alicebartlett
approved these changes
Nov 16, 2016
onishiweb
suggested changes
Nov 16, 2016
| #### OBT verify | ||
| The 6.0.0 release swapped out [`scss-lint`](https://www.npmjs.com/package/gulp-scss-lint) for [`sass-lint`](https://www.npmjs.com/package/gulp-sass-lint). | ||
|
|
||
| If you were supplying your own custom scss-lint configuration you will need to convert it to an equivalent sass-lint configuration, [here is a tool which can do this for you](https://sasstools.github.io/make-sass-lint-config/). The progammatic API and CLI flag was also changed from `scssLintPath` to `sassLintPath`. |
There was a problem hiding this comment.
In the second sentence, the was also changed from might be better as has changed from?
onishiweb
approved these changes
Nov 16, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.