This repository has been archived by the owner on Nov 26, 2021. It is now read-only.
Add update method to switch the current placeholder and/or video #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ure specs have autorender option set to false.
i-like-robots
force-pushed
the
matth/update-method
branch
from
f2c5a8e to
42ba660
Compare
i-like-robots
force-pushed
the
matth/update-method
branch
from
42ba660 to
0422ed8
Compare
| @@ -1,6 +1,18 @@ | |||
| /* global console */ | |||
| import './../../main.js'; | |||
| import OVideo from '../../src/js/video'; | |||
|
|
|||
| document.addEventListener("DOMContentLoaded", function() { | |||
| document.dispatchEvent(new CustomEvent('o.DOMContentLoaded')); | |||
There was a problem hiding this comment.
you don't want to dispatch this if your instantiating it manually
i-like-robots
force-pushed
the
matth/update-method
branch
2 times, most recently
from
17cfe64 to
924fac4
Compare
i-like-robots
force-pushed
the
matth/update-method
branch
from
924fac4 to
9ca7ecf
Compare
| @@ -4,6 +4,8 @@ machine: | |||
| post: | |||
| - npm install -g Financial-Times/origami-build-tools#node4 | |||
| dependencies: | |||
| pre: | |||
| - sudo apt-get update; sudo apt-get install libpango1.0-0 && sudo apt-get install firefox | |||
i-like-robots
force-pushed
the
matth/update-method
branch
6 times, most recently
from
da6fbf1 to
6fb1aec
Compare
|
I reckon we're back to CI stability now =] |
| }); | ||
|
|
||
| afterEach(() => { | ||
| window.fetch.restore(); | ||
| HTMLVideoElement.prototype.canPlayType.restore(); |
There was a problem hiding this comment.
seems like there are indentation issues
|
maybe indentation issues? rest looks good! |
…issues on CI not supporting H264
i-like-robots
force-pushed
the
matth/update-method
branch
from
6fb1aec to
598aed0
Compare
|
Oops, fixed =] |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new method to instances of o-video that enables the video and/or placeholder to be swapped.
Usage like so:
Also fixes some testing trip hazards.