Skip to content
This repository has been archived by the owner on Nov 26, 2021. It is now read-only.

We should track buffering events #124

Closed
sjparkinson opened this issue Sep 13, 2018 · 2 comments · Fixed by #191
Closed

We should track buffering events #124

sjparkinson opened this issue Sep 13, 2018 · 2 comments · Fixed by #191
Labels
component Relates to an Origami component feature New feature request module Relates to an Origami module

Comments

@sjparkinson
Copy link

sjparkinson commented Sep 13, 2018

addEvents(this, ['playing', 'pause', 'ended', 'progress', 'seeked', 'error', 'stalled']);

https://developer.mozilla.org/en-US/docs/Web/Events/waiting

Relates to https://trello.com/c/PhYVid5N/276-loading-videos-on-ftcom.

We've only just enabled streaming miss on the next media API's Fastly service, which should have dramatic improvements to the video load times.

@JakeChampion
Copy link
Contributor

How is the waiting event different from the stalled event we already fire?
https://html.spec.whatwg.org/multipage/media.html#event-media-waiting
https://html.spec.whatwg.org/multipage/media.html#event-media-stalled

@sjparkinson
Copy link
Author

The stall timeout is a user-agent defined length of time, which should be about three seconds. When a media element that is actively attempting to obtain media data has failed to receive any data for a duration equal to the stall timeout, the user agent must queue a task to fire an event named stalled at the element.

from https://html.spec.whatwg.org/multipage/media.html#loading-the-media-resource:event-media-stalled.

Which to me sounds more about hard errors. Whereas the waiting event is more around performance, how often our users are seeing a spinning circle.

@JakeChampion JakeChampion added feature New feature request module Relates to an Origami module labels Mar 24, 2020
chee added a commit that referenced this issue Dec 8, 2020
chee added a commit that referenced this issue Dec 8, 2020
@chee chee closed this as completed in #191 Dec 8, 2020
chee added a commit that referenced this issue Dec 8, 2020
@github-actions github-actions bot added the component Relates to an Origami component label Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component Relates to an Origami component feature New feature request module Relates to an Origami module
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants