Have consumedquantity be 0 for unused commitment #598
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AWS-ZachErdman Based on our conversation back on Oct 9th, I believe we agreed we could close this PR. Please confirm and I will close -- thanks! |
shawnalpay
added
the
needs backlog review
|
Discussed in Oct 31 Members call. Confirmed can close. |
Comments from Members' call on Oct 31:#598 - Zero vs. Non-Consumed Quantity |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we don't force Unused commitment line items to be null for ConsumedQuantity, this is no longer a breaking change between FOCUS 1.0 and FOCUS 1.1. Making it 0 accomplishes the same goal as making it null, without the breaking change.
I also updated the ConsumedUnit to allow for this.