Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Usability Constraints for Aggregation #559

Merged
merged 18 commits into from
Oct 4, 2024
Merged

Adding Usability Constraints for Aggregation #559

merged 18 commits into from
Oct 4, 2024

Conversation

ahullah
Copy link
Contributor

@ahullah ahullah commented Sep 26, 2024

Adding Usability Constraints for Aggregation, to support commitment utilization calculation

@ahullah ahullah requested a review from a team as a code owner September 26, 2024 17:56
@ahullah ahullah self-assigned this Sep 26, 2024
@ahullah ahullah added this to the v1.1 milestone Sep 26, 2024
@ahullah ahullah linked an issue Sep 26, 2024 that may be closed by this pull request
Double Counting (TF-1) #546
Closed
@ahullah ahullah added the consistency/review Consistency Review label Sep 26, 2024
@jpradocueva
Copy link
Contributor

Action Items from Members' call on September 26:

  • [TF1-#559] Members to review the aggregation constraints and provide feedback for final approval next week.

@jpradocueva
Copy link
Contributor

jpradocueva commented Oct 1, 2024 •
edited by ahullah
Loading

Action Items from TF-1 call on October 1st:

@ijurica ijurica mentioned this pull request Oct 2, 2024
Merged
@jpradocueva
Copy link
Contributor

Action Items TF2 call on October 3rd:

  • [TF2-#559] Irena, @ijurica /Chris, @cnharris10 /Udam, @udam-f2 : Incorporate advisory status into the PR to mark the usability constraints for aggregation as optional guidance (rather than mandatory), and then circulate the updated PR for final approval from the group.

@jpradocueva
Copy link
Contributor

Approved by the Members on Oct 3rd call.

@ahullah
Copy link
Contributor Author

ahullah commented Oct 3, 2024

all comments addressed as result of Oct 3rd Members call

@jpradocueva
Copy link
Contributor

jpradocueva commented Oct 3, 2024 •
edited
Loading

Action Items from the Members' call on October 3rd:

  • [Maintainers-#559] Alex, @ahullah to update PR and incorporate changes discussed in today’s call.

@jpradocueva
Copy link
Contributor

@udam-f2, can you please ratify this PR already approved by the Members? Thanks

ahullah and others added 10 commits October 4, 2024 11:59
@ahullah @udam-f2
Update listcost.md with usability constraints
ed10e4d
@ahullah @udam-f2
Update listunitprice.md added usability constraints
0ad6681
@ahullah @udam-f2
Update contractedunitprice.md added usability constraints
54748f8
@ahullah @udam-f2
updates to clarify wording for unit metrics
2122abe
@ahullah @ijurica @udam-f2
Update specification/columns/consumedquantity.md to remove unnecessar…
d1d93ff 
…y usability constraints

Co-authored-by: Irena Jurica <[email protected]>
@ahullah @cnharris10 @udam-f2
Update specification/columns/listunitprice.md to expand 'not supporte…
2dff0e1 
…d' description

Co-authored-by: Christopher Harris <[email protected]>
@ahullah @cnharris10 @udam-f2
Update specification/columns/contractedunitprice.md to expand 'not su…
ff1e201 
…pported' description

Co-authored-by: Christopher Harris <[email protected]>
@ahullah @ijurica @udam-f2
Update specification/columns/contractedcost.md added glossary referen…
1e95615 
…ce , and tightened usage definition.

Co-authored-by: Irena Jurica <[email protected]>
@ahullah @ijurica @udam-f2
Update specification/columns/listcost.md added glossary reference , a…
d82de88 
…nd tightened usage definition.

Co-authored-by: Irena Jurica <[email protected]>
@ahullah @ijurica @udam-f2
Update specification/columns/consumedquantity.md removing whitespace
ddcc14c 
Co-authored-by: Irena Jurica <[email protected]>
@udam-f2 udam-f2 force-pushed the ahullah/542_double_counting branch from 63cb694 to ddcc14c Compare October 4, 2024 18:59
@jpradocueva
Copy link
Contributor

@cnharris10 Hi Chris, can you review if your requested change has been implemented? This is the last task to merge the PR which was already approved by the Members.

@jpradocueva jpradocueva requested a review from cnharris10 October 4, 2024 19:37
@jpradocueva jpradocueva merged commit 32d8e83 into working_draft Oct 4, 2024
1 check passed
@ahullah ahullah deleted the ahullah/542_double_counting branch October 9, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ijurica ijurica ijurica left review comments

@shawnalpay shawnalpay shawnalpay left review comments

@jpradocueva jpradocueva jpradocueva left review comments

@udam-f2 udam-f2 udam-f2 approved these changes

@cnharris10 cnharris10 cnharris10 approved these changes

Assignees

@ahullah ahullah

Labels
consistency/review Consistency Review
Projects
FOCUS WG
Status: W.I.P
Milestone
v1.1
Development

Successfully merging this pull request may close these issues.

Double Counting (TF-1)
6 participants
@ahullah @jpradocueva @cnharris10 @shawnalpay @udam-f2 @ijurica