Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements To Metadata #514

Merged
merged 64 commits into from
Sep 19, 2024
Merged

Improvements To Metadata #514

merged 64 commits into from
Sep 19, 2024

Conversation

rileyjenk
Copy link
Contributor

@rileyjenk rileyjenk commented Aug 2, 2024 •
edited
Loading

Improvements to schema metadata including examples.

@rileyjenk rileyjenk linked an issue Aug 2, 2024 that may be closed by this pull request
Versioning of FOCUS normalized data over long time periods? #332
Closed
@jpradocueva jpradocueva added the P1 label Aug 6, 2024
@jpradocueva jpradocueva added this to the v1.1 milestone Aug 6, 2024
@rileyjenk
Copy link
Contributor Author

Need to add the following examples:

  1. Removal of a column
  2. Fixing a bad schema that is missing a column
  3. changing provider version

@jpradocueva
Copy link
Contributor

jpradocueva commented Aug 9, 2024 •
edited
Loading

Action Items from TF-3 call on Friday, Aug 9th

@rileyjenk next set of action items:

  • [TF3-#514] Riley to update PR Improvements To Metadata #514 with additional examples for provider version changes, schema corrections, and other relevant scenarios.
  • [TF3-#514] Riley to revise the documentation to make it clear that the folder structures in examples are conceptual and not part of the specification.
  • [TF3-#514] Team members to review and provide feedback on the updated examples and documentation.

Action Items from the TF-3 call on Jul 26:

  • TF3-#332 Riley to update the proposal with more detailed examples and clarify the requirements.
  • TF3-#332 Udom and Riley to work together on structuring normative text in the metadata section.
    Team members will review the updated proposal and provide feedback, aiming for a finalized draft in three weeks.

Action items from the Maintainer's call on Aug 5th:

  • [TF3-#332] Riley will draft a JSON representation examples for metadata.

Action Items, TF-3 meeting on Aug 16:

  • [TF3-#332-#514] Riley will merge the provider version PR into Improvements To Metadata #514 and add examples for provider version changes.
  • [TF3-#332-#514] A new schema object will be created for any structural changes to the data, ensuring accurate versioning.
  • The team will continue refining the versioning strategy, ensuring clear communication of changes to end-users.

Action Items, Maintainers, Aug 19:

  • [Maintainers-#514 ] Riley will finalize the content and ensure all examples and use cases are clearly documented.

rileyjenk added 17 commits August 12, 2024 14:08
@rileyjenk
ACME instead of Awesome Corp
f03fa1f
@rileyjenk
Fixing FocusVersion
357651d
@rileyjenk
Adding additional example scenarios
343ff83
@rileyjenk
Removing recommendation for semver.
f8f1b61
@rileyjenk
Clarifying versioning suggestion and separation from Focus Version.
1766cb6
@rileyjenk
Merge pull request #521 from FinOps-Open-Cost-and-Usage-Spec/332-meta…
40f887c 
…data-provider-version

332 metadata provider version
@rileyjenk
Adding schema object scenarios to supporting content.
b22cda4
@rileyjenk
Adding provider version and focus version changes in the examples sec…
9307020 
…tion.
@rileyjenk
Making changes to the example stucture so that the PDF will generate.…
25fd24a 
… Adding more examples and modularizing the reference examples.
@rileyjenk
Actually including all of the changes this time.
e9c6a5f
@rileyjenk
including links in the mdpp
839c4b2
@rileyjenk
Getting all the headers right
5bce5cd
@rileyjenk
more getting headers right
e07b818
@rileyjenk
Fixing appendix references
2b1d51e
@rileyjenk
Merge pull request #522 from FinOps-Open-Cost-and-Usage-Spec/332-meta…
367f4d7 
…data-example-structure-changes

Making changes to the example stucture so that the PDF will generate.…
@rileyjenk
make sure to use actual unordered list.
04e3149
@rileyjenk
More spacing
a134793
@jpradocueva jpradocueva mentioned this pull request Aug 17, 2024
Closed
@jpradocueva
Copy link
Contributor

Action Items from Maintainers' call on Aug 26:

  • [Maintainers-#514] Riley - @rileyjenk : To finalize the structuring of metadata examples and address the PDF generation issue.

@jpradocueva
Copy link
Contributor

Action Items from Members' call on Aug 29:

  • [Members-#514] Riley - @rileyjenk : Finalize any remaining editorial changes before merging.

@jpradocueva
Copy link
Contributor

jpradocueva commented Sep 10, 2024 •
edited
Loading

Action Items from Maintainers' call on Sep 9:

  • [Maintainers-#514] Zach, @AWS-ZachErdman and Riley, @rileyjenk to discuss Zach’s pending comments and present it to the group for final approval.

@jpradocueva
Copy link
Contributor

Approved by the Members on Sep 12 call.

@jpradocueva jpradocueva merged commit 2052862 into working_draft Sep 19, 2024
2 checks passed
@jpradocueva jpradocueva deleted the 332-metadata-versioning-and-reference-clarification branch September 20, 2024 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AWS-ZachErdman AWS-ZachErdman AWS-ZachErdman left review comments

@shawnalpay shawnalpay shawnalpay left review comments

@cnharris10 cnharris10 cnharris10 approved these changes

@ijurica ijurica ijurica approved these changes

@udam-f2 udam-f2 udam-f2 approved these changes

@ahullah ahullah ahullah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
FOCUS WG
Status: W.I.P
Milestone
v1.1
Development

Successfully merging this pull request may close these issues.

Versioning of FOCUS normalized data over long time periods?
8 participants
@rileyjenk @jpradocueva @ahullah @cnharris10 @shawnalpay @udam-f2 @ijurica @AWS-ZachErdman