-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consistency Review: Standardize column specifications for correction charges #547
Comments
ijurica
added
the
discussion topic
Item or question to be discussed by the community
label
Sep 24, 2024
Action items from TF-1 call on Sep 24:
|
ijurica
added a commit
that referenced
this issue
Sep 25, 2024
…c update - Correction handling and value range
ijurica
added a commit
that referenced
this issue
Sep 26, 2024
ijurica
added a commit
that referenced
this issue
Sep 26, 2024
…ge fix (non-negative to positive); Switch back to the version 1.0 definition and description considering it's not the resource or service being metered, but the associated SKUs
ijurica
added a commit
that referenced
this issue
Sep 26, 2024
…cy review - bullet lists and value range
ijurica
added a commit
that referenced
this issue
Sep 26, 2024
…ncy review - bullet lists and value range
ijurica
added a commit
that referenced
this issue
Sep 26, 2024
…c update - limiting to Usage and Purchase
ijurica
added a commit
that referenced
this issue
Oct 1, 2024
…nal version. These two columns will be addressed in a separate PR.
ijurica
added a commit
that referenced
this issue
Oct 1, 2024
…onsumed units and quantities are associated with metered SKUs
shawnalpay
removed
the
discussion topic
Item or question to be discussed by the community
label
Oct 1, 2024
ijurica
added a commit
that referenced
this issue
Oct 2, 2024
… 'MUST NOT be null if ... is Used' with 'MUST NOT be null if ... is not Unused'
ijurica
added a commit
that referenced
this issue
Oct 2, 2024
… 'MUST NOT be null if ... is Used' with 'MUST NOT be null if ... is not Unused'
jpradocueva
added a commit
that referenced
this issue
Oct 3, 2024
…ion charges (#549) Standardize the column specifications, i.e. allow nulls in the case of corrections for all columns except cost metrics, and explicitly define value ranges for all metrics, for the following columns: - PricingUnit - ConsumedUnit - CommitmentDiscountUnit - PricingQuantity - ConsumedQuantity - CommitmentDiscountQuantity - ListCost - ContractedCost - ListUnitPrice - ContractedUnitPrice --- ### NOTE: An initial overall analysis of the current correction handling and value ranges was conducted within this PR. Due to deadlines, **the scope of this particular PR was limited to addressing the following two columns**: - **ConsumedUnit** - **ConsumedQuantity** Please use this [table](https://docs.google.com/spreadsheets/d/1SvaD-PSzxwRKExKYbQXbtEmVPtbhN4HnycOatvLfGPI/edit?gid=1823426118#gid=1823426118) to verify the normative requirements. --------- Co-authored-by: Joaquin <[email protected]>
Comments from Members' call on Oct 31:Analysis: Simple editorial adjustments to normative statements, aimed at improving readability. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Documents:
Description
Review and align how we specify Corrections across the specification. Address nullability and value ranges of metric columns.
1. Nullability
In the case of CommitmentDiscountQuantity, we specified the following:
Meanwhile, for other columns (e.g., costs, quantities, units), we allowed null values for Corrections. For instance:
2. Value ranges of metric columns
While we were explicit in CommitmentDiscountQuantity about expecting positive values and allowing negative values for Corrections, we didn’t explicitly address negative values in other metric columns. (We assumed it was understood that quantities and costs can only be negative in the case of Correction charges and must be non-negative for non-Correction charges.)
Briefly discuss whether this should be applied consistently across the specification.
Proposed Approach
Standardize the specifications, i.e. allow nulls in the case of corrections for all columns except cost metrics, and explicitly define value ranges for all metrics, for the following columns:
GitHub Issue or Reference
Issue #542
Context
No response
Data Submission for Discussion
No response
The text was updated successfully, but these errors were encountered: